Opened 4 years ago

Last modified 3 years ago

#21396 closed enhancement

Add/ignore popular tags: man_made=courtyard, maxweight:signed, natural=crevasse, oneway:moped, opening_hours:signed, operator:type=public, plant:method=photovoltaic, railway:radio — at Version 26

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 22.09
Component: Internal preset Version:
Keywords: unknown_tags courtyard maxweight signed crevasse oneway moped opening_hours operator public plant method photovoltaic railway radio gsm military trench turnlanes turns Cc: skyper, Klumbumbus, francois.lacombe, 1ec5

Description (last modified by skyper)

I need help to add (or ignore if we don't want them) recent popular tags into presets:

jenkins/job/JOSM-Integration/lastCompletedBuild/jdk=JDK8/testReport/org.openstreetmap.josm.data.osm/TaginfoTestIT/testCheckPopularTags__/

  • building=stilt_house (added r18336)
  • craft=grinding_mill - 34201
  • healthcare=alternative (ignored)
  • healthcare:speciality=general - 19538
  • indoor=area - 10145
  • leisure=sports_hall - 12251
  • man_made=courtyard - 21075
  • maxweight:signed=no - 20886 (ignored)
  • military=trench - 10804
  • natural=crevasse - 36226
  • oneway:moped=no - 15649
  • opening_hours:signed=no - 14713 (ignored)
  • operator:type=public - 188232 (ignored)
  • plant:method=photovoltaic - 12060 (#21398)
  • product=food - 34176
  • railway:radio=gsm-r - 83728 (ignored)
  • military=trench - 10168
  • surface=unhewn_cobblestone - 10049 (added r18336)
  • type=turnlanes:turns - 23990
  • vending=parcel_pickup;parcel_mail_in - 10161 (ignored)

I already added or ignored the obvious ones in r18242 / r18245

Change History (26)

comment:1 by skyper, 4 years ago

Oh man, the wiki is just a mess with missing votes on "approved" proposal and lots of wrong information about status of tags.

ignore:

  • maxweight:signed (StreetComplete)
  • opening_hours:signed (StreetComplete)
  • operator:type=public
  • railway:radio (in OpenRailway external preset)

include:

  • man_made=courtyard
  • natural=crevasse
  • plant:method

unsure, ignore for now?

  • oneway:moped, I also find oneway:psv and oneway:bus but with lower numbers.

Just my 2ct

Last edited 4 years ago by skyper (previous) (diff)

comment:2 by skyper, 4 years ago

additionally S:colour: should be added to the ignore list to silence validator see #21336.

comment:3 by skyper, 4 years ago

Description: modified (diff)

I split plant:method off into #21398.

comment:4 by Don-vip, 4 years ago

In 18250/josm:

see #21396, see #21336 - ignore more tags

comment:5 by skyper, 4 years ago

Description: modified (diff)

Coding the presets for man_made=courtyard and natural=crevasse is no big deal. Once again I have trouble finding nice icons.

comment:6 by Don-vip, 4 years ago

that's the most difficult part '

comment:7 by Don-vip, 4 years ago

In 18262/josm:

see #21396 - ignore boundary=historic

comment:8 by Don-vip, 4 years ago

Milestone: 21.0921.10

Milestone renamed

comment:9 by Don-vip, 4 years ago

In 18245/josm:

see #21396 - add flag:type to flagpole preset ; ignore some other popular tags

comment:10 by Don-vip, 4 years ago

Description: modified (diff)
Keywords: military trench turnlanes turns added

comment:11 by Klumbumbus, 4 years ago

I'm not in favor of natural=crevasse. While the total number is quite high (36k) this is used only on a few spots worldwide, see https://taginfo.openstreetmap.org/tags/?key=natural&value=crevasse&filter=all#map.
I randomly checked one spot: https://overpass-turbo.eu/s/1czA There are 2432 ways on this little glacier alone. And with this detailed mapping it is probably highly outdated anyway.
Also the wiki page says it is proposal approved, but on the linked proposal page (https://wiki.openstreetmap.org/wiki/Proposed_features/crevasse) was never discussed or voted. It links to the proposal of natural=ridge which is unrelated.
(If added nevertheless one day, a icon is here after 21440#comment:24)

comment:12 by Klumbumbus, 4 years ago

type=turnlanes:turns

So I would deprecate it in favor of turn:lanes tags, however we also have the plugin "turnlanes". More opinions?

comment:13 by Don-vip, 4 years ago

Agreed to ignore those tags.

comment:14 by skyper, 4 years ago

Thanks for clarifying natural=crevasse. Can we add the unused icon to nodist or have a ticket about natural=crevasse.

Last week, I already wrote a PM to the author of the TurnLanes preset asking about removing it but without answer, so far. Actually, I never took a look at all the plugins about turn:lanes=* but the obsolete relation should not be supported as we have *:lanes=* tagging and the connectivity relations.

comment:15 by Don-vip, 4 years ago

Milestone: 21.1021.11

comment:16 by Don-vip, 4 years ago

Description: modified (diff)

in reply to:  14 comment:17 by skyper, 4 years ago

Replying to skyper:

Thanks for clarifying natural=crevasse. Can we add the unused icon to nodist or have a ticket about natural=crevasse.

How about NewTags, is it ok or do you have problems with the tag in general?

comment:18 by Don-vip, 4 years ago

Milestone: 21.1121.12

Milestone renamed

comment:19 by Don-vip, 4 years ago

In 18336/josm:

see #21396 - add building=stilt_house, surface=unhewn_cobblestone / ignore boundary=census, building=outbuilding

comment:20 by Don-vip, 4 years ago

Milestone: 21.1222.01

comment:21 by skyper, 4 years ago

vending=parcel_pickup;parcel_mail_in is present in presets with a multiselect including both values. Looks like taginfo and the test are not ready for multiple values.

comment:22 by skyper, 4 years ago

Description: modified (diff)

comment:23 by Don-vip, 4 years ago

In 18351/josm:

see #21396 - ignore healthcare=alternative

comment:24 by Don-vip, 4 years ago

In 18356/josm:

see #21396 - ignore vending=parcel_pickup;parcel_mail_in

comment:25 by stoecker, 4 years ago

Milestone: 22.0122.02

Milestone renamed

comment:26 by skyper, 4 years ago

Description: modified (diff)

Replying to Klumbumbus:

I'm not in favor of natural=crevasse. While the total number is quite high (36k) this is used only on a few spots worldwide, see https://taginfo.openstreetmap.org/tags/?key=natural&value=crevasse&filter=all#map.
I randomly checked one spot: https://overpass-turbo.eu/s/1czA There are 2432 ways on this little glacier alone. And with this detailed mapping it is probably highly outdated anyway.
Also the wiki page says it is proposal approved, but on the linked proposal page (https://wiki.openstreetmap.org/wiki/Proposed_features/crevasse) was never discussed or voted. It links to the proposal of natural=ridge which is unrelated.
(If added nevertheless one day, a icon is here after 21440#comment:24)

Ignore it for now.

Replying to Klumbumbus:

type=turnlanes:turns

So I would deprecate it in favor of turn:lanes tags, however we also have the plugin "turnlanes". More opinions?

Replying to skyper:

Last week, I already wrote a PM to the author of the TurnLanes preset asking about removing it but without answer, so far. Actually, I never took a look at all the plugins about turn:lanes=* but the obsolete relation should not be supported as we have *:lanes=* tagging and the connectivity relations.

I never got an answer. The user did not make any changes on OSM the last two years, though.
+1 for deprecating the plugin.
Do we need warning about the obsolete relations or is ignoring the tag enough?


Meanwhile, there are more tags, I have updated the list in the description.

  • healthcare:speciality=general
  • indoor=area

Should be ignored.

  • craft=grinding_mill should be added to the external craft preset and ignored in core
  • product=* should be added to the man_made=work presets but so far only foot and charcoal have high numbers (20k+). The rest has only up to 3k uses and the values on the wiki are not significantly the ones with wiki pages. So I am not sure which ones to add besides food (taginfo
Note: See TracTickets for help on using tickets.