Opened 4 years ago

Last modified 3 years ago

#21396 closed enhancement

Add/ignore popular tags: man_made=courtyard, maxweight:signed, natural=crevasse, oneway:moped, opening_hours:signed, operator:type=public, plant:method=photovoltaic, railway:radio — at Version 16

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 22.09
Component: Internal preset Version:
Keywords: unknown_tags courtyard maxweight signed crevasse oneway moped opening_hours operator public plant method photovoltaic railway radio gsm military trench turnlanes turns Cc: skyper, Klumbumbus, francois.lacombe, 1ec5

Description (last modified by Don-vip)

I need help to add (or ignore if we don't want them) recent popular tags into presets:

jenkins/job/JOSM-Integration/lastCompletedBuild/jdk=JDK8/testReport/org.openstreetmap.josm.data.osm/TaginfoTestIT/testCheckPopularTags__/

  • man_made=courtyard - 18229
  • maxweight:signed=no - 20886 (ignored)
  • natural=crevasse - 36232
  • oneway:moped=no - 10634
  • opening_hours:signed=no - 14713 (ignored)
  • operator:type=public - 188232 (ignored)
  • plant:method=photovoltaic - 12060 (#21398)
  • railway:radio=gsm-r - 83728 (ignored)
  • military=trench - 10168
  • type=turnlanes:turns - 24105
  • surface=unhewn_cobblestone - 10049

I already added or ignored the obvious ones in r18242 / r18245

Change History (16)

comment:1 by skyper, 4 years ago

Oh man, the wiki is just a mess with missing votes on "approved" proposal and lots of wrong information about status of tags.

ignore:

  • maxweight:signed (StreetComplete)
  • opening_hours:signed (StreetComplete)
  • operator:type=public
  • railway:radio (in OpenRailway external preset)

include:

  • man_made=courtyard
  • natural=crevasse
  • plant:method

unsure, ignore for now?

  • oneway:moped, I also find oneway:psv and oneway:bus but with lower numbers.

Just my 2ct

Last edited 4 years ago by skyper (previous) (diff)

comment:2 by skyper, 4 years ago

additionally S:colour: should be added to the ignore list to silence validator see #21336.

comment:3 by skyper, 4 years ago

Description: modified (diff)

I split plant:method off into #21398.

comment:4 by Don-vip, 4 years ago

In 18250/josm:

see #21396, see #21336 - ignore more tags

comment:5 by skyper, 4 years ago

Description: modified (diff)

Coding the presets for man_made=courtyard and natural=crevasse is no big deal. Once again I have trouble finding nice icons.

comment:6 by Don-vip, 4 years ago

that's the most difficult part '

comment:7 by Don-vip, 4 years ago

In 18262/josm:

see #21396 - ignore boundary=historic

comment:8 by Don-vip, 4 years ago

Milestone: 21.0921.10

Milestone renamed

comment:9 by Don-vip, 4 years ago

In 18245/josm:

see #21396 - add flag:type to flagpole preset ; ignore some other popular tags

comment:10 by Don-vip, 4 years ago

Description: modified (diff)
Keywords: military trench turnlanes turns added

comment:11 by Klumbumbus, 4 years ago

I'm not in favor of natural=crevasse. While the total number is quite high (36k) this is used only on a few spots worldwide, see https://taginfo.openstreetmap.org/tags/?key=natural&value=crevasse&filter=all#map.
I randomly checked one spot: https://overpass-turbo.eu/s/1czA There are 2432 ways on this little glacier alone. And with this detailed mapping it is probably highly outdated anyway.
Also the wiki page says it is proposal approved, but on the linked proposal page (https://wiki.openstreetmap.org/wiki/Proposed_features/crevasse) was never discussed or voted. It links to the proposal of natural=ridge which is unrelated.
(If added nevertheless one day, a icon is here after 21440#comment:24)

comment:12 by Klumbumbus, 4 years ago

type=turnlanes:turns

So I would deprecate it in favor of turn:lanes tags, however we also have the plugin "turnlanes". More opinions?

comment:13 by Don-vip, 4 years ago

Agreed to ignore those tags.

comment:14 by skyper, 4 years ago

Thanks for clarifying natural=crevasse. Can we add the unused icon to nodist or have a ticket about natural=crevasse.

Last week, I already wrote a PM to the author of the TurnLanes preset asking about removing it but without answer, so far. Actually, I never took a look at all the plugins about turn:lanes=* but the obsolete relation should not be supported as we have *:lanes=* tagging and the connectivity relations.

comment:15 by Don-vip, 4 years ago

Milestone: 21.1021.11

comment:16 by Don-vip, 4 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.