False positive from RelationChecker?

[zstadler]

What steps will reproduce the problem?

1. Click "File -> Download object..." -> ​relation 3472179 + download referrers + download relation members
2. Click "Validation" -> check there are no "Role verification problem" warnings.
3. Click "Download" -> use current map extent and download all OSM data
4. Click "Validation" again -> find a new "Role verification problem" for relation 3472179 - "Haifa Trail - Downtown".
5. Confirm that all members of this route relation have a "highway" tag using the OSM website or ​this Overpass-Turbo query.

What is the expected result?

1. When a "Role verification problem" warning is found, it should include both two objects involved: the parent relation and the member in order to allow examination. This would be similar to other warning, such as highway crossings.
2. If the warning in step 4 is valid, it should have been presented in step 2.
3. Walking and hiking relations may have members that are relations. If the warning in step 4 is related to ​relation 13207704 "Haifa Trail" and its member ​relation 3472179 "Haifa Trail - Downtown", then the rule should be restricted to members that are way elements. See the OSM wiki on ​Walking Routes.

What happens instead?

1. A new warning is added in step 4 above:

   route("Haifa Trail - Downtown", 62 members)
   Role verification problem
   Role of relation member does not match template expression 'highway || route=ferry' in preset Hiking Route
   Test: Relation checker
   Java: org.openstreetmap.josm.data.validation.tests.RelationChecker
   

2. It is not clear why this warning is given.
3. It is not clear why the warning was not given in step 2.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Build-Date:2021-09-03 01:31:19
Revision:18193
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18193 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (22000)
Memory Usage: 599 MB / 3612 MB (86 MB allocated, but free)
Java version: 1.8.0_301-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-708180f6, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=58381, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (35524)
+ contourmerge (v0.1.8)
+ ejml (35458)
+ geotools (35458)
+ importvec (35567)
+ jaxb (35543)
+ jts (35458)
+ opendata (35803)
+ reverter (35732)
+ undelete (35640)
+ utilsplugin2 (35792)

Last errors/warnings:
- 01070.374 E: Failed to locate image 'https://israelhiking.osm.org.il/content/favicons/favicon.ico'
- 01070.377 E: Failed to locate image 'https://israelhiking.osm.org.il/content/favicons/favicon.ico'
- 02233.457 E: Failed to locate image 'https://israelhiking.osm.org.il/content/favicons/favicon.ico'
- 02233.459 E: Failed to locate image 'https://israelhiking.osm.org.il/content/favicons/favicon.ico'

[zstadler]

screenshot

[mdk]

All members of the relation 3472179 have highway tags with different values:

Even if you change them all of them to the same value (like highway=residential), the warning still exists.

But if you delete the master relation ​13207704, the warning disappear. I have no clue, why the master relation has impact in this case!

[GerdP]

Isn't the warning given for the master relation?

[skyper]

Replying to zstadler <zeev.stadler@…>:

What is the expected result?

1. When a "Role verification problem" warning is found, it should include both two objects involved: the parent relation and the member in order to allow examination. This would be similar to other warning, such as highway crossings.

+1, yes, this would be an enhancement

2. If the warning in step 4 is valid, it should have been presented in step 2.

I guess, the relation was still selected as "Download object" does this. This means that validator was only run on the selection and there are no problems with the "Downtown" part.

3. Walking and hiking relations may have members that are relations. If the warning in step 4 is related to ​relation 13207704 "Haifa Trail" and its member ​relation 3472179 "Haifa Trail - Downtown", then the rule should be restricted to members that are way elements. See the OSM wiki on ​Walking Routes.

​The proposal for the new recreation route relation roles is missing the introduction of route relations as members. In my eyes, a different type=* should be used for such parent relations. We already have superroute and route_master and the first should work in your example.
JOSM checks on the object type and tags of members.

See also my comment on #20731.