Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21299 closed defect (fixed)

Renaming a key deletes the current value

Reported by: GOwin Owned by: team
Priority: normal Milestone: 21.10
Component: Core Version: latest
Keywords: template_report regression Cc:

Description

What steps will reproduce the problem?

  1. Edit an existing key tag by double-clicking on it from the Tags window
  2. When the "change value?" modal window is open, rename the key to something else and press tab to move to the value field
  3. The original value is lost

What is the expected result?

Retain the original value of the tag being edited

What happens instead?

The value is deleted.

You can restore it by pressing Ctrl-Z, but this is not the expected behavior. In previous versions of JOSM, this works as expected.

Please provide any additional information below. Attach a screenshot if possible.

Editing a key:
https://i.imgur.com/qZEetI6.png

lost value after tabbing to the value field
https://i.imgur.com/m6kTYxn.png


Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Revision:18193
Build-Date:2021-09-03 01:31:19
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18193 en) Linux Pop!_OS 20.04 LTS
Memory Usage: 1278 MB / 3144 MB (274 MB allocated, but free)
Java version: 11.0.11+9-Ubuntu-0ubuntu2.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatIntelliJLaf
Screen: :0.0 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: XFCE
Java package: openjdk-11-jre:amd64-11.0.11+9-0ubuntu2~20.04
fonts-noto: fonts-noto:all-20200323-1build1~ubuntu20.04.1
Program arguments: [${HOME}/Documents/default.joz, ${HOME}/Documents/Projects/OpenStreetMap/engagements/IM-TWG NDRRMC/data/PSA/CY2015_schools.geojson]
Dataset consistency test: No problems found

Plugins:
+ Lanes (${version.entry.commit.revision})
+ Mapillary (2.0.0-alpha.34-dirty)
+ OpeningHoursEditor (35640)
+ RoadSigns (35640)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35756)
+ centernode (v1.0.4)
+ contourmerge (v0.1.8)
+ easypresets (1616854084)
+ ejml (35458)
+ flatlaf (35799)
+ geotools (35458)
+ imagery_offset_db (35640)
+ intersection (0.0.7)
+ jaxb (35543)
+ jna (35662)
+ josm-batch-downloader (1.0.4)
+ jts (35458)
+ log4j (35458)
+ mapwithai (1.8.2)
+ measurement (35640)
+ merge-overlap (35640)
+ namemanager (35567)
+ opendata (35803)
+ openqa (0.2.2)
+ reverter (35732)
+ tageditor (35640)
+ terracer (35640)
+ todo (30306)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35792)
+ waydownloader (35640)

Tagging presets:
+ ${HOME}/Documents/Projects/#Kaart/JOSM/Reviewed_Features/reviewed_preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/PhilippinesAddresses&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- ${HOME}/Documents/Projects/#Kaart/JOSM/Kaart Styles 3.1.1.mapcss
- ${HOME}/Documents/Projects/#Kaart/JOSM/geometry_adjusted_paint.mapcss.css
- ${HOME}/Documents/Projects/#Kaart/JOSM/Reviewed_Features/reviewed_features.mapcss
- https://raw.githubusercontent.com/govvin/JOSM-styles/master/age.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- ${HOME}/Documents/Projects/#Kaart/resources/data_age.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Overlapping%20Ways.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart_QC.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart-Styles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- resource://mapcss/Mapillary.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- ${HOME}/Documents/Projects/OpenStreetMap/MapCSS/MapCSS-JOSM-Bicycle-master/cycleway.mapcss
- https://pasharm.github.io/New_basic_style_for_JOSM/New_basic_style.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_PAC.zip

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OsmoseValidations&zip=1
+ https://github.com/KaartGroup/KaartValidator/raw/master/kaart.validator.mapcss
- https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
- https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1

Last errors/warnings:
- 00035.228 E: Failed to locate image 'object-sign-other'
- 00035.294 E: Failed to locate image 'construction--barrier--concrete-block'
- 00035.295 E: Failed to locate image 'construction--barrier--concrete-block'
- 00035.345 E: Failed to locate image 'construction--barrier--concrete-block'
- 00035.346 E: Failed to locate image 'construction--barrier--concrete-block'
- 00035.348 E: Failed to locate image 'object-sign-other'
- 01531.603 W: org.openstreetmap.josm.data.osm.search.SearchParseError: Unexpected token. Expected <right parent>, found <end-of-file>
- 01722.527 W: org.openstreetmap.josm.data.osm.search.SearchParseError: Unexpected token. Expected <right parent>, found <end-of-file>
- 04764.578 W: org.openstreetmap.josm.data.osm.search.SearchParseError: Unexpected token. Expected <right parent>, found <end-of-file>
- 04907.281 W: org.openstreetmap.josm.data.osm.search.SearchParseError: Unexpected token. Expected <right parent>, found <end-of-file>

Attachments (0)

Change History (5)

comment:1 by Don-vip, 3 years ago

Keywords: regression added
Milestone: 21.09

comment:2 by marcello@…, 3 years ago

Does this work since 18221/josm?

comment:3 by skyper, 3 years ago

It works for me, thanks.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-13 20:11:05 +0200 (Mon, 13 Sep 2021)
Revision:18224
Build-Date:2021-09-14 01:31:06
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18224 en) Linux Debian GNU/Linux 11 (bullseye)
Java version: 17-ea+19-Debian-1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarculaLaf

comment:4 by Don-vip, 3 years ago

Resolution: fixed
Status: newclosed

comment:5 by Don-vip, 3 years ago

Milestone: 21.0921.10

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.