Opened 4 years ago
Closed 4 years ago
#21296 closed defect (fixed)
Mapillary filter hides older images, but they remain selectable
| Reported by: | Polarbear-j | Owned by: | taylor.smock |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin mapillary | Version: | |
| Keywords: | Cc: |
Description
JOSM/1.5 (18193 en_GB) Mac OS X 10.14.6
+ Mapillary (2.0.0-alpha.34-dirty)
When working in an area with lots of old imagery, the filter helps to hide e.g. images older than 1 year.
The tile does not show the old images anymore, however they remain invisibly selectable.
The consequence is that when I click an OSM object t work on, I involuntarily click on one of the stale invisible image dot, and it becomes my new mapillary image. Usually their sequences is disconnected, similar to #21295. Quite annoying, since I have to zoom around and click on my intended sequence again.
The example around https://www.mapillary.com/app/?pKey=1448726572130647&lat=51.797032376250996&lng=12.278917715211037&z=19.9
has such old traces.
Let me know if you need more details to reproduce.
This is a fairly easy fix.
I've had to write my own mouse listener and data selector due to the implementation details of the JOSM data selector (if I were to reuse the JOSM data selector, it would be a rather hefty refactor). All I have to do is ensure that I'm not selecting filtered nodes.
Thanks for the bug report.
Fixed in b1a94dc8f9e645d42051a71c9d3f82743ee58bb5 (see https://gitlab.com/smocktaylor/Mapillary/-/merge_requests/165 ).
I'll try to reproduce and fix #21295 and #21298 today, and then make a release with the fix for this bug.