Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#21285 closed enhancement (fixed)

[Patch] Some more warnings on relations — at Version 6

Reported by: skyper Owned by: team
Priority: normal Milestone: 21.10
Component: Core validator Version:
Keywords: template_report relation Cc:

Description (last modified by skyper)

First I thought about warnings for missing primary tags of relations besides type=* but then I thought that adding warnings about wrong access tags for foot and horse routes like the warnings for bicycle routes is not bad either.

Please, find attached patch which

  • adds warnings for type=destination_sign without destination=* and type=building without building=*
  • adds TRANSPORT_MODE=private to no and use_sidepath as problematic values for ways member of route=bicycle/mtb
  • adds route=hiking/running/walking/fitness_trail and route=horse with inappropriate foot=* respectively horse=* to the warning above.
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Revision:18193
Build-Date:2021-09-03 01:31:19
URL:https://josm.openstreetmap.de/svn/trunk

Change History (7)

by skyper, 4 years ago

Attachment: josm_21285.patch added

patch file

comment:1 by skyper, 4 years ago

Milestone: 21.09
Summary: Some more warnings on relations[Patch] Some more warnings on relations

comment:2 by Don-vip, 4 years ago

Do you write patches by hand? The file is named relation.mapcss, not relations.mapcss

comment:3 by Don-vip, 4 years ago

Resolution: fixed
Status: newclosed

In 18199/josm:

fix #21285 - Some more warnings on relations (patch by skyper):

  • adds warnings for type=destination_sign without destination=* and type=building without building=*
  • adds TRANSPORT_MODE=private to no and use_side as problematic values for ways member of route=bicycle/mtb
  • adds route=hiking/running/walking/fitness_trail and route=horse with inappropriate foot=* respectively horse=* to the warning above.

in reply to:  2 comment:4 by skyper, 4 years ago

Replying to Don-vip:

Do you write patches by hand? The file is named relation.mapcss, not relations.mapcss

Ups, sorry, typo. I use diffs and replace/rewrite the heading.

comment:5 by Don-vip, 4 years ago

Milestone: 21.0921.10

Milestone renamed

comment:6 by skyper, 4 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.