Modify

Opened 3 years ago

Last modified 3 years ago

#21247 new defect

NPE: Cannot read field "width" because "this.componentInnards" is null

Reported by: Don-vip Owned by: floscher
Priority: normal Milestone:
Component: Plugin wikipedia Version:
Keywords: template_report Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. dragged and dropped https://www.openstreetmap.org/relation/43356
  2. selected node with wikidata tag
  3. tried to display info in wikidata dialog

What is the expected result?

no crash

What happens instead?

NPE

Please provide any additional information below. Attach a screenshot if possible.


Revision:18173
Is-Local-Build:true
Build-Date:2021-08-25 15:01:04

Identification: JOSM/1.5 (18173 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19042)
Memory Usage: 330 MB / 4088 MB (126 MB allocated, but free)
Java version: 16.0.1+9, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 2560×1440 (scaling 1.00×1.00) \Display1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_FR
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-ea, --add-opens=java.base/java.io=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/java.text=ALL-UNNAMED, --add-opens=java.base/java.util=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.desktop/java.awt=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --module-path=C:\Java\javafx-sdk-16\lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-alpha.32)
+ MicrosoftStreetside (35779)
+ apache-commons (35524)
+ apache-http (35589)
+ ejml (35458)
+ geotools (35458)
+ javafx (35807)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ opendata (35803)
+ turnrestrictions (35640)
+ utilsplugin2 (35792)
+ wikidata (1.2.3)
+ wikipedia (1.1.4)

Last errors/warnings:
- 00160.432 E: javax.swing.JProgressBar[,0,0,480x17,alignmentX=0.0,alignmentY=0.0,border=,flags=0,maximumSize=,minimumSize=,preferredSize=,orientation=HORIZONTAL,paintBorder=true,paintString=true,progressString=Download statements for Q30030732…,indeterminateString=true]
- 00160.433 E: 	at java.base/java.lang.Thread.getStackTrace(Thread.java:1596)
- 00160.435 E: 	at org.openstreetmap.josm.gui.util.CheckThreadViolationRepaintManager.checkThreadViolations(CheckThreadViolationRepaintManager.java:54)
- 00160.438 E: 	at org.openstreetmap.josm.gui.util.CheckThreadViolationRepaintManager.addDirtyRegion(CheckThreadViolationRepaintManager.java:45)
- 00160.439 E: 	at java.desktop/javax.swing.JComponent.repaint(JComponent.java:4845)
- 00160.440 E: 	at java.desktop/java.awt.Component.repaint(Component.java:3397)
- 00160.441 E: 	at java.desktop/javax.swing.JProgressBar.setString(JProgressBar.java:507)
- 00160.445 E: 	at org.wikipedia.gui.ProgressJPanel.showProgress(ProgressJPanel.java:20)
- 00160.446 E: 	at org.wikipedia.gui.WikidataInfoClaimPanel.lambda$downloadStatementsFor$1(WikidataInfoClaimPanel.java:35)
- 00160.449 E: 	at java.base/java.lang.Thread.run(Thread.java:831)



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (22) of main
java.lang.NullPointerException: Cannot read field "width" because "this.componentInnards" is null
	at java.desktop/javax.swing.plaf.basic.BasicProgressBarUI.updateSizes(BasicProgressBarUI.java:542)
	at java.desktop/javax.swing.plaf.basic.BasicProgressBarUI.getBox(BasicProgressBarUI.java:499)
	at java.desktop/com.sun.java.swing.plaf.windows.WindowsProgressBarUI.getBox(WindowsProgressBarUI.java:251)
	at java.desktop/com.sun.java.swing.plaf.windows.WindowsProgressBarUI.paintIndeterminate(WindowsProgressBarUI.java:305)
	at java.desktop/javax.swing.plaf.basic.BasicProgressBarUI.paint(BasicProgressBarUI.java:464)
	at java.desktop/javax.swing.plaf.ComponentUI.update(ComponentUI.java:161)
	at java.desktop/javax.swing.JComponent.paintComponent(JComponent.java:797)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1074)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JComponent.paintToOffscreen(JComponent.java:5264)
	at java.desktop/javax.swing.RepaintManager$PaintManager.paintDoubleBufferedImpl(RepaintManager.java:1643)
	at java.desktop/javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(RepaintManager.java:1618)
	at java.desktop/javax.swing.RepaintManager$PaintManager.paint(RepaintManager.java:1556)
	at java.desktop/javax.swing.RepaintManager.paint(RepaintManager.java:1323)
	at java.desktop/javax.swing.JComponent._paintImmediately(JComponent.java:5212)
	at java.desktop/javax.swing.JComponent.paintImmediately(JComponent.java:5022)
	at java.desktop/javax.swing.RepaintManager$4.run(RepaintManager.java:865)
	at java.desktop/javax.swing.RepaintManager$4.run(RepaintManager.java:848)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:848)
	at java.desktop/javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:823)
	at java.desktop/javax.swing.RepaintManager.prePaintDirtyRegions(RepaintManager.java:772)
	at java.desktop/javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1884)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:316)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

Attachments (1)

wikidatabug.jpg (221.2 KB ) - added by Don-vip 3 years ago.

Download all attachments as: .zip

Change History (7)

by Don-vip, 3 years ago

Attachment: wikidatabug.jpg added

comment:1 by Don-vip, 3 years ago

Description: modified (diff)

comment:2 by Don-vip, 3 years ago

Component: Plugin wikidataPlugin wikipedia
Owner: changed from taylor.smock to floscher

This dialog is from the wikipedia plugin. I don't think it's a good idea to create a new "wikidata" plugin, it's really confusing.

comment:3 by taylor.smock, 3 years ago

This looks like it is actually from the wikipedia plugin with their support for standard wikidata.

My wikidata plugin is only for OSM Wiki Data items ( https://wiki.openstreetmap.org/wiki/Data_items ) and, as the plugin description says, is only for adding/modifying (modifying not implemented) OSM wiki data items. It will open a web page if the wiki data item already exists.

The wikidata plugin only starts doing stuff once you right-click on a tag.

in reply to:  2 comment:4 by taylor.smock, 3 years ago

Replying to Don-vip:

This dialog is from the wikipedia plugin. I don't think it's a good idea to create a new "wikidata" plugin, it's really confusing.

I really didn't have a better name for it. I'm open to suggestions (it literally exists only as a method for me/other people to add or view wiki data items at this time).

Version 0, edited 3 years ago by taylor.smock (next)

comment:5 by Don-vip, 3 years ago

osmwiki-dataitem maybe?

in reply to:  5 comment:6 by taylor.smock, 3 years ago

Replying to Don-vip:

osmwiki-dataitem maybe?

Works for me. I'll make the change ASAP.

EDIT: And it should appear as osmwiki-dataitem in ~30 minutes.

Last edited 3 years ago by taylor.smock (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain floscher.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from floscher to the specified user.
Next status will be 'needinfo'. The owner will be changed from floscher to Don-vip.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from floscher to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.