Modify

Opened 4 years ago

Closed 4 years ago

#21238 closed enhancement (wontfix)

Validation rule for preventing accidentally removing address nodes

Reported by: Cartographer10 Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:

Description

It is quite common to tag an address as a node inside a building. Next, information like shops and amenity can be added to these address nodes. When services stopped, users often remove the node without realizing they also remove the address nodes. This happens by accident but especially in cities, it is hard to notice the missing address because of the high density of nodes.

I therefore would like the request a validation role that warns the user when they remove a node containin address information. I can think of two possible rules:

1: In the most simple form. It can check for a node with address information without checking whether the node contains additional information like shops or amenities.
2: Another option is that the rule only triggers when the node has address information AND other information like shops and amenities.

Whether option 1 or 2 is implemented, the user should get a gentle warning that address information is beeing deleted. An autofix would be to restore the node.

I would like to hear what you think of this.

Attachments (0)

Change History (4)

comment:1 by skyper, 4 years ago

Personally, I always change the primary key to disused:*=* and do not remove these nodes at all.
With removed buildings, I keep the object and use remove:building=* plus removed:addr:*=* to keep the information and even single address nodes are worth retagging instead of removing.

I think this is a general problem not restricted to addresses and people need to learn to use replace geometry and life-cycle prefix instead of removing objects completely.

in reply to:  1 comment:2 by Cartographer10, 4 years ago

Replying to skyper:

Personally, I always change the primary key to disused:*=* and do not remove these nodes at all.
With removed buildings, I keep the object and use remove:building=* plus removed:addr:*=* to keep the information and even single address nodes are worth retagging instead of removing.

I think this is a general problem not restricted to addresses and people need to learn to use replace geometry and life-cycle prefix instead of removing objects completely.

The addresses should stay unchanged, so no use of life-cycle tagging. The problem is that people sometimes accidentially remove address information when they delete a node that contains for example a shop or amenity that is no longer there.

comment:3 by Don-vip, 4 years ago

Summary: Feature request: Validation rule for preventing accidentally removing address nodesValidation rule for preventing accidentally removing address nodes

comment:4 by GerdP, 4 years ago

Resolution: wontfix
Status: newclosed

I don't see how this could be implemented in Validator since a deleted node is not validated. Such a validation might be done in the DeleteAction but I think it's a bit too special. It's not enough to check if the deleted node has addr:* tags as the same addr:* tags might be on a building or on another node. Quite complex and possibly confusing when the mapper really wants to fix a wrong address.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.