Modify

Opened 15 years ago

Closed 15 years ago

#2122 closed enhancement (fixed)

[patch] Disable preset menu items depending on selected object

Reported by: ce Owned by: framm
Priority: minor Milestone:
Component: Internal preset Version:
Keywords: Cc:

Description

In the presets we now have the "allowed" object types for each dialog. What about en- and disabling menu entries depending on the object type? For example, natural=water only is allowed for closed areas. Rises some questions, though. What if there are different elements in the selection?

Attachments (1)

UI Improve Tagging.zip (2.9 KB ) - added by xeen 15 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by stoecker, 15 years ago

Different elements are already filtered out. A presets only applies to correct types.

I see one problem with this thought: You cannot see the preset dialog when you have no data selected and thus it is also impossible to get the link to further information.

Maybe we can only change the appearance of the menu without disabling it totally.

comment:2 by stoecker, 15 years ago

Owner: changed from ce to framm

comment:3 by xeen, 15 years ago

What about disabling the <OK> button (ugh, should be <Apply Preset> anyway)? If we know beforehand that the selection isn't suitable we should warn the user beforehand, too. (Think of someone accidentally losing his/her selection and entering all the tags just to find out it didn't apply and the fun can start again…)

by xeen, 15 years ago

Attachment: UI Improve Tagging.zip added

comment:4 by xeen, 15 years ago

Summary: Disable preset menu items depending on selected object[patch] Disable preset menu items depending on selected object

Although this improves usability a bit, it doesn't solve the original problem.

An idea might be to add *s in front of unsuitable presets. It's already used for relation when JOSM has found an error/a problem so people might understand this.

comment:5 by stoecker, 15 years ago

Resolution: fixed
Status: newclosed

Fixed in r1427.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.