Modify ↓

Opened 4 years ago

Closed 4 years ago

#21195 closed defect (fixed)

[PATCH] auto_tools crashes when the returned SplitWayCommand is null

Reported by: taylor.smock Owned by: Rub21
Priority: normal Milestone:
Component: Plugin auto_tools Version:
Keywords: Cc:

Description (last modified by taylor.smock)

From an email I just got from a co-worker:

I've been running into a lot of issues with my autotools plugin. [...] the best fix I have is to uninstall/reinstall it and restart JOSM but it only works about half of the time. The error I'm sending you comes up when I try to split a road that has a route or a relation. 

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-08-02 19:44:04 +0200 (Mon, 02 Aug 2021)
Build-Date:2021-08-02 18:26:20
Revision:18118
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18118 en) Mac OS X 10.16
OS Build number: macOS 11.4 (20F71)
Memory Usage: 1490 MB / 3641 MB (839 MB allocated, but free)
Java version: 1.8.0_301-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1 2240×1260 (scaling 1.00×1.00) Display 2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 2240×1260
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-6d609c46, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-6742c05d.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1623509627)
+ FastDraw (35640)
+ KartaView (374)
+ Mapillary (2.0.0-alpha.30-dirty)
+ apache-commons (35524)
+ apache-http (35589)
+ auto_tools (79)
+ graphview (35640)
+ imagery_offset_db (35640)
+ javafx-osx (35655)
+ jna (35662)
+ mapwithai (1.8.2)
+ markseen (14)
+ osm-obj-info (66)
+ reverter (35732)
+ rex (53)
+ scripting (30798)
+ turnlanes (35640)
+ turnrestrictions (35640)
+ utilsplugin2 (35792)

Tagging presets:
+ <josm.userdata>/EasyPresets.xml

Map paint styles:
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Sanitas_Paintstyle.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart-Styles.mapcss
+ ${HOME}/Desktop/RC-DestinationTest-Kaart-Styles.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Overlapping%20Ways.mapcss
- https://raw.githubusercontent.com/KaartGroup/Kaart-Styles/master/Kaart_QC_Mexico.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Validator rules:
+ https://raw.githubusercontent.com/KaartGroup/KaartValidator/master/kaart.durazno.validator.mapcss

Last errors/warnings:
- 00018.482 E: Failed to locate image 'MapWithAI'
- 00853.123 E: Failed to locate image 'preference.png'
- 00884.222 E: Unsupported savable layer type: TMSLayer
- 00886.433 E: Unsupported savable layer type: TMSLayer
- 00888.480 E: Failed to locate image 'preference.png'
- 04925.977 W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>
- 07620.395 E: Unsupported savable layer type: ValidatorLayer
- 08021.223 E: Handled by bug report queue: java.lang.IllegalArgumentException: Parameter 'c' must not be null
- 08058.607 E: Handled by bug report queue: java.lang.IllegalArgumentException: Parameter 'c' must not be null
- 08091.048 E: Handled by bug report queue: java.lang.IllegalArgumentException: Parameter 'c' must not be null



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (41) of javawsApplicationThreadGroup
java.lang.IllegalArgumentException: Parameter 'c' must not be null
at org.openstreetmap.josm.tools.CheckParameterUtil.ensureParameterNotNull(CheckParameterUtil.java:26)
at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:298)
at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:354)
at org.openstreetmap.josm.plugins.auto_tools.actions.SplittingTool.SplitRoad(SplittingTool.java:366)
at org.openstreetmap.josm.plugins.auto_tools.actions.SplittingTool.mouseReleased(SplittingTool.java:134)
at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:290)
at java.awt.Component.processMouseEvent(Component.java:6539)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
at java.awt.Component.processEvent(Component.java:6304)
at java.awt.Container.processEvent(Container.java:2239)
at java.awt.Component.dispatchEventImpl(Component.java:4889)
at java.awt.Container.dispatchEventImpl(Container.java:2297)
at java.awt.Component.dispatchEvent(Component.java:4711)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4904)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4535)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4476)
at java.awt.Container.dispatchEventImpl(Container.java:2283)
at java.awt.Window.dispatchEventImpl(Window.java:2746)
at java.awt.Component.dispatchEvent(Component.java:4711)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84)
at java.awt.EventQueue$4.run(EventQueue.java:733)
at java.awt.EventQueue$4.run(EventQueue.java:731)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Notes:
I'll be opening a PR on ​https://github.com/JOSM/auto-tools with the patch.

EDIT: PR available at ​https://github.com/JOSM/auto-tools/pull/27

Attachments (0)

Change History (2)

comment:1 by taylor.smock, 4 years ago

Description: modified (diff)

comment:2 by Don-vip, 4 years ago

Resolution: → fixed
Status: new → closed

Fixed with ​https://github.com/JOSM/auto-tools/releases/tag/v1.3.4

Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Rub21.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.