[Patch] Context specific help (F1) not properly working in menus

[skyper]

What steps will reproduce the problem?

1. Select a way
2. Hoover the mouse over File menu -> Download data
3. Press F1

What is the expected result?

The existing wiki page for the action is opened in help browser

What happens instead?

I land at the main help page.

Please provide any additional information below. Attach a screenshot if possible.

Hoovering over the button in Main Toolbar, the proper path is used but all menu items are affected.
Both Dark modes suffer the same issue.

Does not happen when using metal

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-07-20 19:23:32 +0200 (Tue, 20 Jul 2021)
Revision:18078
Build-Date:2021-07-20 17:59:14

Look and Feel: com.formdev.flatlaf.FlatIntelliJLaf

Plugins:
+ flatlaf (35734)

[skyper]

Oh no, again the flatlaf plugin and all menu items suffer the same issue. I changed the description.

[DevCharly]

This also depends on the used Java version.
In Java 11 and FlatLaf it works.
In Java 8 and FlatLaf it does not...

[DevCharly]

Ok, forget my previous comment. It has nothing to do with used Java version.

It depends on whether the menu fits into the main window or not.

If it fits, then a light-weight popup is used and F1 works as expected.

If the menu is large and does not fit into the main window, then a heavy-weight popup is used to display the menu (because it is partly outside of the main frame). Then the implementation in JOSM's HelpAction class does not find the menu item and F1 does not work correctly.

This is not related to FlatLaf.
It occurs in all L&Fs.

[DevCharly]

I've attached a patch that first looks into MenuSelectionManager for selected menu item.

[skyper]

Replying to DevCharly:

It depends on whether the menu fits into the main window or not.

No, it happens in all cases with the flatlaf plugin. I first noticed this with utilsplugin2 items like "More Tools -> Split Object" or "Selection -> Undo Selection" which work fine with "Metal".

[DevCharly]

No, it happens in all cases with the flatlaf plugin.

Aha, yes, then you're on Linux or macOS, right?
On these two platforms, FlatLaf always uses heavy-weight popups because then the OS adds drop shadows to the popup.
I've tested only on Windows. Sorry.

Anyway, the patch should work on all platforms :)

[skyper]

Arrg, sorry I forgot:

Identification: JOSM/1.5 (18097 en) Linux Debian GNU/Linux 10 (buster)
Java version: 11.0.12+7-post-Debian-2deb10u1, Debian, OpenJDK 64-Bit Server VM

[Don-vip]

In 18111/josm:

fix #21148 - fix context specific help (F1) usage in menus (patch by DevCharly)

[Don-vip]

Thanks!