Modify

Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#21069 closed enhancement (fixed)

[Patch] "Role 'section' is not among expected values 'device/from/to/force'" while creating average_speed enforcement

Reported by: Talkless Owned by: team
Priority: normal Milestone: 21.06
Component: Internal preset Version: tested
Keywords: validator enforcement relation member role Cc: Talkless

Description

I get complain about "section" field for these relations using JOSM 17919 on Debian Sid:

https://www.openstreetmap.org/relation/12921878
https://www.openstreetmap.org/relation/12921877

There's "section" key for "average_speed" enforcement:
JOSM 17919 on Debian Sid.

https://wiki.openstreetmap.org/wiki/Relation:enforcement#Members

Attachments (2)

josm_21069.patch (2.5 KB) - added by skyper 12 months ago.
patch
josm_21069_v2.patch (2.6 KB) - added by skyper 12 months ago.
patch version 2 with correct order of values and additional keys

Download all attachments as: .zip

Change History (22)

comment:1 Changed 12 months ago by skyper

Component: Core validatorInternal preset
Keywords: validator enforment relation member role added
Version: tested

comment:2 Changed 12 months ago by skyper

Keywords: enforcement added; enforment removed

comment:3 Changed 12 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17948/josm:

fix #21069 - Add enforcement=average_speed with role section

comment:4 Changed 12 months ago by Klumbumbus

Milestone: 21.06
Type: defectenhancement

comment:5 Changed 12 months ago by skyper

Do not think that will work. We need an own preset for "average_speed".

comment:6 Changed 12 months ago by skyper

"section" is required, but only for this type of enforcement.

Changed 12 months ago by skyper

Attachment: josm_21069.patch added

patch

comment:7 Changed 12 months ago by skyper

josm_21069_v2.patch should do the trick.

Changed 12 months ago by skyper

Attachment: josm_21069_v2.patch added

patch version 2 with correct order of values and additional keys

comment:8 Changed 12 months ago by skyper

Resolution: fixed
Status: closedreopened
Summary: "Role 'section' is not among expected values 'device/from/to/force'" while creating average_speed enforcement[Patch] "Role 'section' is not among expected values 'device/from/to/force'" while creating average_speed enforcement

comment:9 Changed 12 months ago by Klumbumbus

In 17949/josm:

see #21069 - Split up enforcement=average_speed preset, small adjustmenst to the presets (patch by skyper partly included)

comment:10 Changed 12 months ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

comment:11 Changed 12 months ago by skyper

Thanks.

comment:12 Changed 12 months ago by skyper

Looking at the examples, member_expression might be useful:

<roles>
                <role key="device" text="location of enforcement device" requisite="required" type="node,way,closedway" member_expression="highway=speed_camera" />
                <role key="from" text="node on way where enforcement starts" requisite="required" type="node" />
                <role key="to" text="where enforcement ends" requisite="optional" type="node" />
                <role key="section" text="ways forming the section of messurement" requisite="required" type="way" member_expression="highway" />
            </roles>

comment:13 Changed 12 months ago by Klumbumbus

highway=speed_camera is a different tagging method and not needed for the enforcement relation. But we can add the member expression for the section role.

comment:14 in reply to:  13 ; Changed 12 months ago by skyper

Replying to Klumbumbus:

highway=speed_camera is a different tagging method and not needed for the enforcement relation. But we can add the member expression for the section role.

Just wonder how the "device" should be tagged then, but well, I am fine with only the expression for "section".

comment:15 Changed 12 months ago by Klumbumbus

In 17951/josm:

see #21069 - Add member_expression to enforcement=average_speed preset (patch by skyper)

comment:16 in reply to:  14 Changed 12 months ago by Klumbumbus

Replying to skyper:

Just wonder how the "device" should be tagged then

Just blank, without tags.

comment:17 Changed 12 months ago by skyper

Maybe, it is worth thinking about splitting all enforcement relations into own presets for each enforcement=* by creating one more level (subgroup) in the menu. Common parts, like roles, could still use chunks. New ticket?

comment:18 Changed 12 months ago by Don-vip

In 17958/josm:

see #21069 - fix i18n typo

comment:19 in reply to:  17 ; Changed 12 months ago by Don-vip

Replying to skyper:

New ticket?

Yes please. Working on the 21.06 release right now.

comment:20 in reply to:  19 Changed 12 months ago by skyper

Replying to Don-vip:

In 17958/josm:

see #21069 - fix i18n typo

Thank you.

Replying to Don-vip:

Replying to skyper:

New ticket?

Yes please. Working on the 21.06 release right now.

Good to know that there will be release this week. Thanks for your work.
See #21081 for the new ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.