#20960 closed enhancement (fixed)
[Patch] Warn about construction=* without or conflicting primary tag
| Reported by: | skyper | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 22.03 |
| Component: | Core validator | Version: | |
| Keywords: | template_report construction missing conflicting tag | Cc: |
Description
Inspired by #17607.
What steps will reproduce the problem?
- Have a way with only
construction=* - Run Validator
What is the expected result?
A warning about missing primary tag
What happens instead?
No warning
OR
What steps will reproduce the problem?
- Have a way with
railway=railandconstruction=rail - Run Validator
What is the expected result?
A warning about conflicting tags
What happens instead?
No warning
Please provide any additional information below. Attach a screenshot if possible.
Not sure if a autofix can be offered but suggestions can be made.
The four primary tags highway, railway, building and landuse use construction=*, atm.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-06-02 23:14:11 +0200 (Wed, 02 Jun 2021) Revision:17921 Build-Date:2021-06-03 01:31:07 URL:https://josm.openstreetmap.de/svn/trunk
Attachments (2)
Change History (13)
comment:1 Changed 19 months ago by
| Owner: | changed from team to skyper |
|---|
Changed 19 months ago by
| Attachment: | josm_20960.patch added |
|---|
comment:2 Changed 19 months ago by
| Milestone: | → 21.11 |
|---|---|
| Owner: | changed from skyper to team |
| Summary: | Warn about construction=* without or conflicting primary tag → [Patch] Warn about construction=* without or conflicting primary tag |
Please find attached patch which updates/adds the rules for construction=*.
I am not sure if waterway=* might be a fifth primary tag where the combination with construction=* is valid.
I gonna work on #20963 which should be fixed together with this ticket.
comment:3 Changed 19 months ago by
| Milestone: | 21.11 |
|---|---|
| Owner: | changed from team to skyper |
Have to little rework the rule and need to find/create a nice icon for building=construction.
comment:4 Changed 19 months ago by
Changed 19 months ago by
| Attachment: | josm_20960v2.patch added |
|---|
version 2: does not warn about waterway; rearrange some rules to use ordered placeholder numbers
comment:5 Changed 15 months ago by
| Milestone: | → 22.03 |
|---|---|
| Owner: | changed from skyper to team |
#20963 has a patch now.
comment:8 follow-up: 9 Changed 13 months ago by
The latest patch seems to lack [!railway] in this line:
area[construction][!building][!highway][!landuse]:closed,
Example: https://www.openstreetmap.org/way/1052080206 , a platform under construction
comment:9 Changed 13 months ago by
Replying to Famlam:
The latest patch seems to lack
[!railway]in this line:
area[construction][!building][!highway][!landuse]:closed,Example: https://www.openstreetmap.org/way/1052080206 , a platform under construction
See #22039
patch