[PATCH] UnsupportedOperationException when right-clicking on an MVT Layer (non-expert mode)

[taylor.smock]

What steps will reproduce the problem?

1. Add an MVT layer
2. Ensure that expert mode is off
3. Right click on the MVT layer

What is the expected result?

No crash. :)

What happens instead?

Crash :(

Please provide any additional information below. Attach a screenshot if possible.

Revision:17913
Is-Local-Build:true
Build-Date:2021-05-27 10:09:22

Identification: JOSM/1.5 (17913 SVN en) Mac OS X 10.16
OS Build number: macOS 11.3.1 (20E241)
Memory Usage: 388 MB / 4096 MB (133 MB allocated, but free)
Java version: 15.0.2+7, N/A, OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 188945233 1920×1080 (scaling 1.00×1.00) Display 188945231 1920×1080 (scaling 1.00×1.00) Display 69733382 1680×1050 (scaling 2.00×2.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-javaagent:/Users/tsmock/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/211.7142.45/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=50910:${HOME}/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/211.7142.45/IntelliJ IDEA.app/Contents/bin, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-alpha.5)
+ apache-commons (35524)
+ apache-http (35589)
+ auto_sidewalk (UNKNOWN)
+ jna (35662)
+ mapwithai (1.8.2)
+ todo (30306)
+ utilsplugin2 (35691)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 00046.085 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00046.775 E: Failed to locate image 'regulatory--texts--g1'
- 00046.776 E: Failed to locate image 'regulatory--texts--g2'
- 00046.948 E: Failed to locate image 'void--car-mount'
- 00046.949 E: Failed to locate image 'void--dynamic'
- 00046.950 E: Failed to locate image 'void--ego-vehicle'
- 00046.951 E: Failed to locate image 'void--ground'
- 00046.952 E: Failed to locate image 'void--static'
- 00047.133 E: Failed to locate image 'warning--kangaroo-crossing--g1'
- 00065.832 E: Handled by bug report queue: java.lang.UnsupportedOperationException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (25) of main
java.lang.UnsupportedOperationException
	at java.base/java.util.AbstractList.remove(AbstractList.java:167)
	at org.openstreetmap.josm.gui.dialogs.LayerListPopup.<init>(LayerListPopup.java:120)
	at org.openstreetmap.josm.gui.dialogs.LayerListDialog$PopupMenuHandler.showMenu(LayerListDialog.java:735)
	at org.openstreetmap.josm.gui.widgets.PopupMenuLauncher.checkFocusAndShowMenu(PopupMenuLauncher.java:107)
	at org.openstreetmap.josm.gui.widgets.PopupMenuLauncher.launch(PopupMenuLauncher.java:81)
	at org.openstreetmap.josm.gui.widgets.PopupMenuLauncher.processEvent(PopupMenuLauncher.java:68)
	at org.openstreetmap.josm.gui.widgets.PopupMenuLauncher.mousePressed(PopupMenuLauncher.java:58)
	at java.desktop/java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:288)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6611)
	at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
	at java.desktop/java.awt.Component.processEvent(Component.java:6379)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4990)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4822)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4919)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4545)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4489)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2769)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4822)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[Don-vip]

In 17998/josm:

fix #20950 - UnsupportedOperationException when right-clicking on an MVT Layer in non-expert mode (patch by taylor.smock)