[patch] leisure=dog_park preset suggests to add area; validator complains about area

[Famlam]

What steps will reproduce the problem?

1. Add a leisure=dog_park area using the corresponding preset
2. Tick area in the preset dialog box
3. Run the validator

What is the expected result?

As the validator states area is unnecessary, the preset shouldn't suggest it

What happens instead?

Validator warning about unnecessary tag area + preset offering area

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-04-27 20:35:33 +0200 (Tue, 27 Apr 2021)
Build-Date:2021-04-27 21:58:39
Revision:17833
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17833 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 1006 MB / 1820 MB (306 MB allocated, but free)
Java version: 1.8.0_291-b10, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: nl_NL
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35640)
+ SimplifyArea (35640)
+ imagery_offset_db (35640)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35732)
+ tageditor (35640)
+ turnlanes-tagging (288)
+ undelete (35640)
+ utilsplugin2 (35691)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

[skyper]

patch only removing area=yes

[skyper]

patch removing barrier=* in addition

[skyper]

I have attached two different patch files:

• josm_20924.patch​ only removes the offending area=yes
• josm_20924_no_barrier.patch​ also removes the barrier=* combo this tagging can lead to problems and we do not offer it on any similar park area.
  • I thought fenced=yes is the better tag but it is marked as deprecated without any source to a discussion: ​Tag:fenced=yes

[Famlam]

barrier=* is part of that wiki page from the moment it left the proposal stage, so I guess it could stay in for now?
(I think fenced was removed as you'd then also need to invent walled etc; besides having two tags for the same purpose)

Obviously, the barrier would be better drawn as a separate way, unless you have to throw your dog over the fence to get it in, but since the nodes would overlap - and a fence cannot be an area - I understand that it's convenient to combine them ;)

[skyper]

Exactly, there are better ways and the current situations contradicts "one object one feature" and should not be offered. Usually, the fence is not directly on the border of the park but close to it.

In my eyes, fenced=yes is not a "barrier", in first place, but a property of an area and not identical with barrier=fence.

[Famlam]

I'm fine with removing it too; it's a preset, not a validator rule, so those that prefer it, can still add it manually :)

[skyper]

Ping

[Klumbumbus]

In 17922/josm:

fix #20924 - Remove area=yes and barrier=* from leisure=dog_park preset (patch by skyper)

[skyper]

Thanks