Opened 12 months ago

Last modified 8 months ago

#20909 new defect

"No area style for multipolygon" produces lots of duplicates

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: template_report multipolygon area style Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have a multipolygon with only access=*, area=*, lanes=*, layer=*, level=*, lit=*, name=* or ref=* (list probably incomplete)
  2. Run Validator

What is the expected result?

One warning about missing tag describing the area and no informal warning: No area style for multipolygon

What happens instead?

  • Multiple warnings on different warning levels, some I will address in #20902.
    • always but on different warning levels: Multipolygon tags - tag describing the area is missing from java TagChecker
    • always informal warning: No area style for multipolygon from java MultipolygonTest

Please provide any additional information below. Attach a screenshot if possible.

The list of tags is probably not complete and it is not restricted to only one additional tag besides type=multipolygon.
With only surface=* beside type, there exists even a higher mapcss warning, which makes both informal warnings from both java test useless duplicates.
These two java test need to be synced to only produce one warning.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-05-17 21:27:21 +0200 (Mon, 17 May 2021)
Build-Date:2021-05-18 01:31:02

Attachments (0)

Change History (5)

comment:1 Changed 12 months ago by skyper

Description: modified (diff)

comment:2 Changed 8 months ago by GerdP

TagChecker shows either an error with tag describing the area is missing or a warning tag describing the area might be missing, note the different texts.
The message from MultipolygonTest depends on the active map style, the message from TagChecker doesn't.
I don't see them as duplicate messages, I consider it as a hint that explains why a multipolygon is not filled with any colour.
Anyhow, I wouldn't mind to message produced by MultipolygonTest.

comment:3 Changed 8 months ago by skyper

I was a bit to eager to find unneeded warnings in this case. Feel free to close as invalid.
MultipolygonTest will not help much and is present in the tooltip. Maybe, adding in active map styles would help.

comment:4 Changed 8 months ago by GerdP

We can use the same wording as in other messages about style:
No area style for multipolygon with the currently used mappaint style

comment:5 Changed 8 months ago by skyper

Yes, makes sense.

Modify Ticket

Change Properties
Set your email in Preferences
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to skyper
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.