Modify

Opened 12 months ago

Last modified 8 months ago

#20879 reopened enhancement

History browser: which version changed a tag (git blame)?

Reported by: simon04 Owned by: simon04
Priority: normal Milestone:
Component: Core Version:
Keywords: history version Cc: gaben

Description (last modified by simon04)

The tag table of the history browser could display for each line (for each key) in which version this value has been changed, similar to git blame.


Attachments (2)

Screenshot 2021-05-12 at 23.13.33.png (1.5 MB) - added by simon04 12 months ago.
Screenshot 2021-05-17 at 21.08.48.png (400.5 KB) - added by simon04 12 months ago.

Download all attachments as: .zip

Change History (19)

Changed 12 months ago by simon04

comment:1 Changed 12 months ago by simon04

Description: modified (diff)

comment:2 Changed 12 months ago by simon04

In 17886/josm:

see #20879 - Extract TagTableModel.getDiffItemType

comment:3 Changed 12 months ago by simon04

Resolution: fixed
Status: assignedclosed

In 17887/josm:

fix #20879 - History browser: which version changed a tag (git blame)?

comment:4 Changed 12 months ago by simon04

Cc: gaben added
Resolution: fixed
Status: closedreopened

Replying to gaben in ticket:20880#comment:6:

If the modifications not uploaded yet, the version number is messed up. After upload the since column becomes empty.

Last edited 12 months ago by gaben (previous) (diff)

comment:5 Changed 12 months ago by gaben

Oh sorry, I reopened the wrong ticket.

Aside from the bug, it's a nice feature I already like it, thank you! :D

comment:6 Changed 12 months ago by simon04

In 17903/josm:

see #20879 - History browser: display version "*" if tag change has not been committed

Changed 12 months ago by simon04

comment:7 Changed 12 months ago by skyper

I like the new feature but it can be irritating if a tag was added more than once. Right now there is no differences made and only the last version is shown. Especially, in cases of reverts and undelete actions this does not work well.

comment:8 Changed 12 months ago by gaben

I have the same feeling but can't figure out a nice way to present it to the GUI. How do you want to see it?

comment:9 Changed 12 months ago by skyper

A different text color or background color could be used if the tag was not added for the first time.

If I get it right, #20880 and this ticket could be tied together and the version number could get the background from #20880. Then there would be enough space for three or four different colors.

comment:10 Changed 12 months ago by simon04

Idea: we could add two colour gutters:

  • gutter to the left of keys shows when the key was first added
  • gutter to the right of values shows when the value was last changed (added in r17887 and r17890)

comment:12 Changed 11 months ago by Klumbumbus

Milestone: 21.0521.06

comment:13 Changed 11 months ago by Don-vip

Milestone: 21.0621.07

comment:14 Changed 10 months ago by Don-vip

Milestone: 21.0721.08

comment:15 Changed 9 months ago by Don-vip

Milestone: 21.0821.09

comment:16 Changed 8 months ago by Don-vip

Milestone: 21.09

comment:17 Changed 8 months ago by gaben

Keywords: history version added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The owner will remain simon04.
as The resolution will be set.
to The owner will be changed from simon04 to the specified user.
The owner will change to simon04
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.