Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#20854 closed defect (fixed)

[Patch] Changeset Manager: Header name of Changeset State is incorrect.

Reported by: leni Owned by: simon04
Priority: normal Milestone: 21.05
Component: Core Version: latest
Keywords: template_report changeset manager status Cc:

Description

What steps will reproduce the problem?

  1. I open the changeset manager window

What is the expected result?

the column name with the status = "status"

What happens instead?

the column name with the status is displayed "open"

with the French language, it's different, For a group with "status=Open" it's displayed "État" instead of "Ouvert" and in the Changesets panel it's displayed "Ouvrir" instead of "Ouvert"

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-04-27 20:35:33 +0200 (Tue, 27 Apr 2021)
Build-Date:2021-04-27 21:58:39
Revision:17833
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17833 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 247 MB / 247 MB (104 MB allocated, but free)
Java version: 1.8.0_271-b09, Oracle Corporation, Java HotSpot(TM) Client VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1616852928)
+ Mapillary (1.5.37.6)
+ PicLayer (2a9aa7a)
+ apache-commons (35524)
+ apache-http (35589)
+ contourmerge (v0.1.6)
+ ejml (35458)
+ flatlaf (35734)
+ geotools (35458)
+ imagery_offset_db (35640)
+ indoorhelper (1.2.0)
+ javafx-windows (35655)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ photo_geotagging (35738)
+ photoadjust (35640)
+ reverter (35732)
+ scripting (30798)
+ shrinkwrap (v1.0.4)
+ tageditor (35640)
+ todo (30306)
+ utilsplugin2 (35691)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- <josm.pref>\styles\sit.mapcss
+ <josm.pref>\styles\sit.mapcss

Validator rules:
+ https://raw.githubusercontent.com/nlehuby/transport_mapcss/master/transport.validator.mapcss

Last errors/warnings:
- 00026.661 E: Failed to locate image 'object--wire-group'
- 00026.795 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00027.567 E: Failed to locate image 'regulatory--texts--g1'
- 00027.568 E: Failed to locate image 'regulatory--texts--g2'
- 00027.717 E: Failed to locate image 'void--car-mount'
- 00027.718 E: Failed to locate image 'void--dynamic'
- 00027.719 E: Failed to locate image 'void--ego-vehicle'
- 00027.720 E: Failed to locate image 'void--ground'
- 00027.721 E: Failed to locate image 'void--static'
- 00028.155 E: Failed to locate image 'warning--kangaroo-crossing--g1'

Attachments (3)

ChangesetStatusEn.png (122.3 KB ) - added by leni 4 years ago.
Changeset status English
ChangesetStatusFr.png (136.6 KB ) - added by leni 4 years ago.
Changeset status French
josm_20854_changeset_manager_status.patch (598 bytes ) - added by skyper 4 years ago.
patch correcting the name of the column to "Status"

Download all attachments as: .zip

Change History (12)

by leni, 4 years ago

Attachment: ChangesetStatusEn.png added

Changeset status English

by leni, 4 years ago

Attachment: ChangesetStatusFr.png added

Changeset status French

comment:1 by skyper, 4 years ago

Keywords: i18n status added

Translation is made at Launchpad, see Translations#Software. Please, recheck/update the translation.

Only, if there are several meanings/translations because of different context we need to respect this in the source code to separate the strings and give translators a hint.

Last edited 4 years ago by skyper (previous) (diff)

comment:2 by skyper, 4 years ago

Summary: Changeset StateTranslation of Changeset State

comment:3 by leni, 4 years ago

I'm sorry my English is not very good, I may have misspoken the description, but the original error is not the translation.
The modification "Changeset State → Translation of Changeset State" is not correct

the translation may be related to the original problem

What is the expected result?

the column name with the status = "status"

What happens instead?

the column name with the status = "open"

See attached file ChangesetStatusEn.png

comment:4 by skyper, 4 years ago

Keywords: changeset manager added; i18n removed
Summary: Translation of Changeset StateChangeset Manager: Header name of Changeset State is incorrect.

Oh, yes, sorry, you are right. Gonna provide a patch in a minute.

by skyper, 4 years ago

patch correcting the name of the column to "Status"

comment:5 by skyper, 4 years ago

Summary: Changeset Manager: Header name of Changeset State is incorrect.[Patch] Changeset Manager: Header name of Changeset State is incorrect.
Version: latest

Please, find attached patch changing the name of the column to "Status"

comment:6 by simon04, 4 years ago

Milestone: 21.05
Owner: changed from team to simon04
Status: newassigned

comment:7 by simon04, 4 years ago

Resolution: fixed
Status: assignedclosed

In 17869/josm:

fix #20854 - Changeset Manager: fix header name "status" (patch by skyper)

comment:8 by leni, 4 years ago

thanks for the patch

comment:9 by leni, 4 years ago

now the translation is also ok

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.