Modify ↓

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#20839 closed defect (fixed)

Notification about hidden objects by filter without any active filter

Reported by: skyper Owned by: team
Priority: normal Milestone: 21.05
Component: Core validator Version: latest
Keywords: template_report filter notification hidden object Cc: GerdP

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have some data downloaded
  2. Have no active filter
  3. Run validator without selection

What is the expected result?

No notification about hidden objects

What happens instead?

Notification about hidden objects

Please provide any additional information below. Attach a screenshot if possible.

In fact, I did not activate any filter in this session.
I have one deactivated filter with the checkbox for "hide" checked.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-05-02 10:12:56 +0200 (Sun, 02 May 2021)
Revision:17856
Build-Date:2021-05-03 01:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (9)

comment:1 by skyper, 4 years ago

Cc: GerdP added

comment:2 by GerdP, 4 years ago

Ah, yes, code should check isDisabledAndHidden() instead of isDrawable().

comment:3 by skyper, 4 years ago

Description: modified (diff)

comment:4 by GerdP, 4 years ago

Resolution: → fixed
Status: new → closed

In 17858/josm:

fix #20839: Notification about hidden objects by filter without any active filter
regression of r17852

  • check isDisabledAndHidden() instead of !isDrawable()

comment:5 by skyper, 4 years ago

BTW, the help button is too big. The icon needs to be scaled down.

comment:6 by GerdP, 4 years ago

I agree, but I don't know where this has to be done.

comment:7 by skyper, 4 years ago

How about simply changing the default size of the image to 24x24. I just tried but I have to play a bit more with inkscape to get the correct center.

in reply to:  6 comment:8 by skyper, 4 years ago

Replying to GerdP:

I agree, but I don't know where this has to be done.

Lets see if somebody can figure this out: #20862.

comment:9 by Don-vip, 4 years ago

Milestone: → 21.05

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.