Modify

Opened 3 years ago

Closed 3 years ago

#20801 closed enhancement (duplicate)

add building=digester

Reported by: francians Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: template_report building digester power generator Cc: francois.lacombe

Description

What is the expected result?

Open "Biomass Power Generator" preset and being able to specify if the building is also a digester.
I suggest something along these lines:

            <item name="Biomass Power Generator" icon="presets/power/power_source-biofuel.svg" type="node,closedway,multipolygon" preset_name_label="true">
                <key key="generator:source" value="biomass" />
                <reference ref="power_generator" />
                <combo key="generator:method" text="Method" values_context="generator method" values="anaerobic_digestion,combustion,gasification" />
                <combo key="generator:type" text="Generator Type" values_searchable="true">
                    <list_entry value="bioreactor" short_description="anaerobic_digestion / combustion" />
                    <list_entry value="pyrolysis" short_description="" />
                    <list_entry value="steam_generator" short_description="combustion" />
                    <list_entry value="steam_turbine" short_description="combustion" />
                </combo>
+                <check key="building" text="Digester" value_on="digester" disable_off="true" />
                <reference ref="power_output" />
            </item> <!-- Biomass Power Generator -->

Please see:
https://wiki.openstreetmap.org/wiki/Tag:building%3Ddigester

I also added building=digester to the:

https://josm.openstreetmap.de/wiki/Presets/NewTags

But would be a bigger effort to add this line there.

Please let me know
Cheers
Francesco

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-04-01 23:17:01 +0200 (Thu, 01 Apr 2021)
Revision:17702
Build-Date:2021-04-01 21:46:03
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17702 it) Linux Arch Linux
Memory Usage: 334 MB / 3976 MB (137 MB allocated, but free)
Java version: 15.0.2+7, N/A, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1,00×1,00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: it_IT.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Desktop environment: GNOME
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.37.3)
+ OpeningHoursEditor (35640)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35669)
+ ejml (35458)
+ geotools (35458)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ mapwithai (1.7.1.4)
+ opendata (35640)
+ reverter (35688)
+ turnrestrictions (35640)
+ utilsplugin2 (35691)
+ wikipedia (1.1.4)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip
+ ${HOME}/JOSM/Presets_NewTags/Presets_NewTags-preset.xml
+ https://raw.githubusercontent.com/osmItalia/cai_josm_preset/master/cai.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Validator rules:
- https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ ${HOME}/git/map-this-way/MapThisWay.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/ItalySpecific&zip=1

Last errors/warnings:
- 00018,799 E: Impossibile trovare l'immagine 'object--wire-group'
- 00018,936 E: Impossibile trovare l'immagine 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00019,433 E: Impossibile trovare l'immagine 'regulatory--texts--g1'
- 00019,434 E: Impossibile trovare l'immagine 'regulatory--texts--g2'
- 00019,525 E: Impossibile trovare l'immagine 'void--car-mount'
- 00019,525 E: Impossibile trovare l'immagine 'void--dynamic'
- 00019,526 E: Impossibile trovare l'immagine 'void--ego-vehicle'
- 00019,526 E: Impossibile trovare l'immagine 'void--ground'
- 00019,527 E: Impossibile trovare l'immagine 'void--static'
- 00019,681 E: Impossibile trovare l'immagine 'warning--kangaroo-crossing--g1'

Attachments (0)

Change History (7)

comment:1 by skyper, 3 years ago

Cc: francois.lacombe added
Component: CoreInternal preset
Keywords: building digester power generator added; presets removed

As far as I remember, it is better to have two separate objects for the building and the power generator, e.g. the building as area and a node or an area inside as generator. Is digester a special case?

Anyway, numbers are low and the tag building=digester is stated as "in use" (no accepted proposal).

Last edited 3 years ago by skyper (previous) (diff)

comment:2 by skyper, 3 years ago

Summary: Default preset: add digesteradd digester

comment:3 by skyper, 3 years ago

Summary: add digesteradd building=digester

comment:4 by francians, 3 years ago

Hello,

If you think is better to have two separate objects then feel free to close the issue.
I may have been treated by the wiki.
Thanks and sorry for the bothering
Francesco

comment:5 by Klumbumbus, 3 years ago

building=digester was already added to the general bulding preset in r17510.

comment:6 by skyper, 3 years ago

Invalid, Wontfix or Duplicate?

comment:7 by Klumbumbus, 3 years ago

Resolution: duplicate
Status: newclosed

Closed as duplicate of #20474.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.