Opened 3 years ago
#20783 new defect
Common hours override exceptions
Reported by: | anonymous | Owned by: | boman |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Plugin openinghourseditor | Version: | |
Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Enter common opening hours for five days of the week.
- Expand the opening hours for Monday and Thursday.
What is the expected result?
The value should start with the common hours Tuesday to Friday, followed by the exception on Monday and Thursday:
Tu-Fr 08:00-19:00; Mo,Th 08:00-20:00
What happens instead?
The value starts with the exceptions, followed by the common hours which overrides the exception for Thursday, according to https://openingh.openstreetmap.de/evaluation_tool/ :
Mo,Th 08:00-20:00; Tu-Fr 08:00-19:00
Please provide any additional information below. Attach a screenshot if possible.
Revision:17560 Build-Date:2021-03-15 17:34:50 Identification: JOSM/1.5 (17560 de) Mac OS X 10.16 OS Build number: macOS 11.2.3 (20D91) Memory Usage: 1748 MB / 8192 MB (859 MB allocated, but free) Java version: 15.0.2+7, Azul Systems, Inc., OpenJDK 64-Bit Server VM Look and Feel: com.apple.laf.AquaLookAndFeel Screen: Display 69734272 1440×900 (scaling 2.00×2.00) Display 1007295233 2560×1600 (scaling 1.00×1.00) Maximum Screen Size: 2560×1600 Best cursor sizes: 16×16→16×16, 32×32→32×32 VM arguments: [--add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --module-path=/Applications/JOSM.app/Contents/app/mods] Dataset consistency test: No problems found Plugins: + Mapillary (1.5.37.3) + OpeningHoursEditor (35640) + apache-commons (35524) + apache-http (35589) + buildings_tools (35669) + jna (35662) + ta<user.name>itor + terracer (35640) + turnlanes-tagging + turnrestrictions (35640) + undelete (35640) + utilsplugin2 (35691) Tagging presets: + https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/NewParkingFeatures&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Radwege&zip=1 + https://osmtools.de/josm/steps.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1 Map paint styles: - https://josm.openstreetmap.de/josmfile?page=Styles/iD&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Schools&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1 - https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1 + resource://mapcss/Mapillary.mapcss + https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1 Last errors/warnings: - 00019.287 E: Fehler beim Laden des Bildes 'regulatory--dual-lanes-cyclists-and-pedestrians--g1' - 00019.982 E: Fehler beim Laden des Bildes 'regulatory--texts--g1' - 00019.983 E: Fehler beim Laden des Bildes 'regulatory--texts--g2' - 00020.106 E: Fehler beim Laden des Bildes 'void--car-mount' - 00020.107 E: Fehler beim Laden des Bildes 'void--dynamic' - 00020.108 E: Fehler beim Laden des Bildes 'void--ego-vehicle' - 00020.109 E: Fehler beim Laden des Bildes 'void--ground' - 00020.110 E: Fehler beim Laden des Bildes 'void--static' - 00020.273 E: Fehler beim Laden des Bildes 'warning--kangaroo-crossing--g1' - 411029.506 E: Kommunikation mit dem OSM-Server fehlgeschlagen - null
Attachments (4)
Change History (4)
by , 3 years ago
Attachment: | GeneratingTheWrongString.png added |
---|
by , 3 years ago
Attachment: | CallingEditorWithWrongString.png added |
---|
Upon saving the wrong string and re-opening the editor, the graphical representation has changed but is still wrong. Incidentally, the correct string is represented the same way.
by , 3 years ago
Attachment: | EvaluatingWrongString.png added |
---|
Actual result with the wrong string, showing Mo-Fr: The extended hours on Th (22nd) are missing.
by , 3 years ago
Attachment: | EvaluatingCorrectString.png added |
---|
Actual result with the correct string, showing Mo-Fr: The extended hours on Th (22nd) are now there.
Editor window with graphically entered hours and wrong string generated