[patch] Code improvements

[gaben]

While I looked for JOSM core functionality, found these minor issues and fixed them. There is no intended functionality change, only semantics.

[taylor.smock]

Just out of curiosity, why did you change L816 in src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java like so:

-            } catch (NumberFormatException ignore) {
-                Logging.trace(ignore);
+            } catch (NumberFormatException e) {
+               Logging.trace(e);

ignore seems to be fairly clear as to why we continue without re-throwing, where e isn't.

[GerdP]

My understanding of the "TODO: convert this to switch/case and make sure the parsing still works" is that there is a script which parses the java source to extract the shortcuts and this script may not work. I don't know know how to make sure. Do you?

[taylor.smock]

I think the script might be hidden on the server somewhere, and not in the source, so I can't check. I don't know who has server access. I think don-vip and stoecker have access, but I don't know about anyone else.

[simon04]

Replying to taylor.smock:

Just out of curiosity, why did you change L816 in src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java like so:

IntelliJ by default reports the warning "'catch' parameter named 'ignore' is used", but those warnings are configurable.

[gaben]

Replying to taylor.smock:

Just out of curiosity, why did you change L816 in src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java

As Simon said, by default those reported by IntelliJ. An error is ignored by inspection definition when it's not used in the catch block, example: trunk/src/com/kitfox/svg/xml/XMLParseUtil.java#L359.

Replying to GerdP:
Speaking of the removed TODO, I have no idea, the script is probably not public. At least you can test if it still works :)

[simon04]

In 17786/josm:

see #20741 - Fix typos in code and strings (patch by gaben)

[simon04]

In 17787/josm:

fix #20741 - Various code simplifications (patch by gaben)

[simon04]

I've split your patch in two commits. I've excluded the ignore exception variable name, and the patch around "TODO: convert this to switch/case and make sure the parsing still works" (since I cannot).

[gaben]

Thank you and sorry for the extra work. I was having issues keeping the patch up to date because you made changes faster than I found issues 😄