[Patch] Unnecessary tag area=yes not reported for waterway=riverbank

[zelonewolf@…]

The combination natural=water + area=yes reports an unnecessary tag error, because area=yes is not needed.

This warning should also be shown for waterway=riverbank + area=yes.

[zelonewolf@…]

Simple test case demonstrating the issue

[GerdP]

This should fix it:

resources/data/validator/unnecessary.mapcss

@@ -30 +30 @@
   fixRemove: "{2.key}";
 }
 
-/* #14256, #15664 */
+/* #14256, #15664, #20681 */
 area:closed[highway=rest_area][area?],
 area:closed[highway=services][area?],
 area:closed[aeroway=aerodrome][area?],
+way:closed[waterway=riverbank][area?],
 area:closed[aeroway=helipad][area?] {
   throwWarning: tr("{0} is unnecessary for {1}", "{2.tag}", "{1.tag}");
   group: tr("unnecessary tag");

[skyper]

We have a general mapcss rule for area=* on MP-Relations, mean-while. Probably, all area could be changed to way up front.

[GerdP]

Good catch. I didn't use way instead of area intentionally, I just started with a different block containing rule

way:closed[natural ][area?],

[GerdP]

I just tried a multipolygon with natural=way + area=yes and there is no warning that area=yes is not necessary for multipolygons (also not without the patch). What's wrong?

[skyper]

Do you have a selection, maybe only the way and not the relation?

* Warnings (2)
  * area on a relation (1)
  * Unknown property value - Value 'way' for key 'natural' is unknown, maybe 'bay' is meant? (1)
* Other (1)
  * No area style for multipolygon (1)

[GerdP]

no

[skyper]

This it what I get with r18235 and without any download area with the relation selected:

Replying to skyper:

* Warnings (2)
  * area on a relation (1)
  * Unknown property value - Value 'way' for key 'natural' is unknown, maybe 'bay' is meant? (1)
* Other (1)
  * No area style for multipolygon (1)

[GerdP]

Which test produces the area on a relation message? Maybe a local version?

[skyper]

Nice try, no I made sure to disable all my local files and enable all core rules.

geometry.mapcss

[GerdP]

Oops, sorry, I meant natural=water + area=yes. I see the test

relation[area?] {
  throwWarning: tr("{0} on a relation", "{0.key}");
  fixRemove: "{0.key}";
}

but it doesn't seem to work for my example. Have to debug this ...

[skyper]

natural=water + area=yes on MP relation:

* Warnings (1)
 * area on a relation (1)
* Other (1)
 * missing tag - natural=water without water (1)

[GerdP]

OK, tried with tested before. Get the same result with r18235 now.

[Don-vip]

Milestone renamed

[GerdP]

In 18271/josm:

fix #20681: Unnecessary tag area=yes not reported for waterway=riverbank

• add check for waterway=riverbank
• change filter area to way to avoid duplicate warnings for relations with area=yes