Hang upon exit if Mapillary download is active

[richlv]

JOSM hung upon exiting - this might be related to the Mapillary download being active at that time.
This happened when testing a bit older JOSM version.

2021-03-18 21:52:32.694 INFO: GET https://a.mapillary.com/v3/sequences?client_id=UTZhSnNFdGpxSEFFREUwb01GYzlXZzpjNGViMzQxMTIzMjY0MjZm&bbox=25.0614506%2C57.2177941%2C25.0747641%2C57.2224915 -> HTTP/1.1 200 (1.2 s; 189 kB)
2021-03-18 21:52:33.183 INFO: GET https://a.mapillary.com/v3/sequences?client_id=UTZhSnNFdGpxSEFFREUwb01GYzlXZzpjNGViMzQxMTIzMjY0MjZm&bbox=25.0614506%2C57.2177941%2C25.0747641%2C57.2224915 → 200 (8 sequences in 0.49 s)
2021-03-18 21:52:35.751 INFO: Changeset updater inactive
2021-03-18 21:52:35.751 INFO: Message notifier inactive
2021-03-18 21:52:35.752 INFO: RemoteControl::Server /127.0.0.1:8111 stopped.
2021-03-18 21:52:35.754 INFO: RemoteControl::Server /0:0:0:0:0:0:0:1:8111 stopped.
2021-03-18 21:52:35.927 INFO: GET https://a.mapillary.com/v3/images?client_id=UTZhSnNFdGpxSEFFREUwb01GYzlXZzpjNGViMzQxMTIzMjY0MjZm&bbox=25.0614506%2C57.2177941%2C25.0747641%2C57.2224915 -> HTTP/1.1 200 (2.7 s; 71.8 kB)
2021-03-18 21:52:36.176 SEVERE: java.lang.InterruptedException
java.lang.InterruptedException
	at java.base/java.lang.Object.wait(Native Method)
	at java.base/java.util.concurrent.ForkJoinTask.externalInterruptibleAwaitDone(ForkJoinTask.java:356)
	at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1004)
	at org.openstreetmap.josm.plugins.mapillary.io.download.MapillaryDownloader$ForkJoinTaskRunnable.run(MapillaryDownloader.java:80)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at java.base/java.lang.Thread.run(Thread.java:832)

2021-03-18 21:52:36.177 java[77486:2085129] 2021-03-18 21:52:36.176 SEVERE: java.lang.InterruptedException
java.lang.InterruptedException
	at java.base/java.lang.Object.wait(Native Method)
	at java.base/java.util.concurrent.ForkJoinTask.externalInterruptibleAwaitDone(ForkJoinTask.java:356)
	at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1004)
	at org.openstreetmap.josm.plugins.mapillary.io.download.MapillaryDownloader$ForkJoinTaskRunnable.run(MapillaryDownloader.java:80)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at java.base/java.lang.Thread.run(Thread.java:832)

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-03-15 13:53:05 +0100 (Mon, 15 Mar 2021)
Revision:17564
Build-Date:2021-03-16 02:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17564 en_GB) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H524)
Memory Usage: 300 MB / 4096 MB (110 MB allocated, but free)
Java version: 15.0.1+9-18, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1127230987 1920×1080 (scaling 1.00×1.00) Display 69733382 1680×1050 (scaling 2.00×2.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32

Plugins:
+ InfoMode (35543)
+ Mapillary (1.5.37.2)
+ PicLayer (2a9aa7a)
+ apache-commons (35524)
+ apache-http (35589)
+ ejml (35458)
+ geotools (35458)
+ imagery_offset_db (35640)
+ javafx-osx (35655)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ pbf (35720)
+ photo_geotagging (35715)
+ reverter (35688)
+ utilsplugin2 (35691)

Map paint styles:
+ /Users/richlv/Desktop/ChangeFontSize.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 00003.401 E: java.lang.UnsatisfiedLinkError: <josm.userdata>/plugins/javafx/libjfxmedia_avf.dylib: dlopen(<josm.userdata>/plugins/javafx/libjfxmedia_avf.dylib, 1): Library not loaded: @rpath/libgstreamer-lite.dylib
- 00003.410 E: java.lang.UnsatisfiedLinkError: <josm.userdata>/plugins/javafx/libfxplugins.dylib: dlopen(<josm.userdata>/plugins/javafx/libfxplugins.dylib, 1): Library not loaded: @rpath/libgstreamer-lite.dylib
- 00007.635 W: Failed to load Mappaint styles from '/Users/richlv/Desktop/ChangeFontSize.mapcss'. Exception was: java.nio.file.NoSuchFileException: /Users/richlv/Desktop/ChangeFontSize.mapcss
- 00007.635 E: java.nio.file.NoSuchFileException: /Users/richlv/Desktop/ChangeFontSize.mapcss
- 00007.637 E: java.nio.file.NoSuchFileException: /Users/richlv/Desktop
- 00007.638 W: Initializing map style /Users/richlv/Desktop/ChangeFontSize.mapcss completed in 3 ms (1 errors, 0 warnings)

[taylor.smock]

Thanks for the bug report. I won't be spending time fixing this, since the download code is going to be completely reworked for the v4 API, and I'd rather get that chunk of work done before the current API (v3) disappears and breaks Mapillary for everyone.

Specifically,

The Mapillary API v3 will continue working for several weeks after we launch API v4 in May 2021, but will no longer retrieve data that has been uploaded after the API v4 launch date. The upload endpoints in API v3 will no longer be active, and all new image uploads must go through API v4 after launch. Client IDs created for API v3 will not be viable for API v4, and developers must register a new client ID to use API v4. From now until the end of May, API v3 will continue to function, but it is recommended that developers start using the upcoming API v4 sandbox to begin migrating their apps during March, April, and May in order for a seamless transition.

So I'm working on #17177 for JOSM vector tile support. :)

For more information, see ​https://blog.mapillary.com/update/2021/03/03/preparing-for-the-new-mapillary-api.html .