"Select Duplicate Buildings" tool in the Mapathoner plug-in does not work

[stevenjo1@…]

What steps will reproduce the problem?

1. Ensure nothing is selected in the task area (HOTOSM mapping)
2. Click on tool in drop-down Mapathoner menu.

What is the expected result?

Duplicated buildings will be highlighted in the task area.

What happens instead?

Error message: "An unexpected exception occurred that may have come from the 'mapathoner' plug-in. According to the information within the plug-in, the author is qeef."

Please provide any additional information below. Attach a screenshot if possible.

Mac OS Big Sur 11.2.3
JOSM v. 17560
First noticed the issue a day or two ago, but didn't file a bug report.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-03-14 18:17:35 +0100 (Sun, 14 Mar 2021)
Build-Date:2021-03-14 17:21:03
Revision:17560
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17560 en_GB) Mac OS X 10.16
OS Build number: macOS 11.2.3 (20D91)
Memory Usage: 1265 MB / 1820 MB (549 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69985664 2048×1152 (scaling 1.00×1.00)
Maximum Screen Size: 2048×1152
Best cursor sizes: 16×16→16×16, 32×32→32×32
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-404951c4, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-6da8adbe.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ CADTools (1008)
+ buildings_tools (35669)
+ mapathoner (1.1.6)
+ markseen (14)
+ measurement (35640)
+ scripting (30798)
+ terracer (35640)
+ utilsplugin2 (35691)

Map paint styles:
+ https://github.com/MissingMaps/josm_styles/archive/master.zip
- ${HOME}/Desktop/JOSM me, baby./applepaintstyles-main.zip

Last errors/warnings:
- 34770.780 W: Unknown remote control parameter title, skipping it
- 82644.730 W: Unknown remote control parameter max_zoom, skipping it
- 82644.731 W: Unknown remote control parameter title, skipping it
- 86372.708 W: Unknown remote control parameter max_zoom, skipping it
- 86372.708 W: Unknown remote control parameter title, skipping it
- 88315.389 W: Unknown remote control parameter max_zoom, skipping it
- 88315.390 W: Unknown remote control parameter title, skipping it
- 89912.202 W: Unknown remote control parameter max_zoom, skipping it
- 89912.202 W: Unknown remote control parameter title, skipping it
- 90071.877 E: Handled by bug report queue: java.lang.NoSuchMethodError: org.openstreetmap.josm.data.osm.QuadBuckets.add(Lorg/openstreetmap/josm/data/osm/IPrimitive;)Z



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (52) of javawsApplicationThreadGroup
java.lang.NoSuchMethodError: org.openstreetmap.josm.data.osm.QuadBuckets.add(Lorg/openstreetmap/josm/data/osm/IPrimitive;)Z
	at org.openstreetmap.josm.plugins.mapathoner.SelectDuplicateBuildingAction.actionPerformed(SelectDuplicateBuildingAction.java:103)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
	at com.apple.laf.ScreenMenuItem.actionPerformed(ScreenMenuItem.java:125)
	at java.awt.MenuItem.processActionEvent(MenuItem.java:669)
	at java.awt.MenuItem.processEvent(MenuItem.java:628)
	at java.awt.MenuComponent.dispatchEventImpl(MenuComponent.java:357)
	at java.awt.MenuComponent.dispatchEvent(MenuComponent.java:345)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:763)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84)
	at java.awt.EventQueue$4.run(EventQueue.java:733)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:730)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[skyper]

@Admins
Who is the maintainer of the plugin? Please add it to trac.

[taylor.smock]

Replying to skyper:

@Admins
Who is the maintainer of the plugin? Please add it to trac.

qeef is. I don't know if he is on JOSM trac (as an actual user).

He asked on IRC about testing the plugin to see if it crashed.

See https://josm.openstreetmap.de/ticket/20363#comment:8 for a similar crash log.

qeef uses tested in his build.gradle for the compile version, and there have been a few releases since this crash.

---
Copy/pasted IRC logs
---

qeef
Hi guys, could someone with macOS JOSM test the mapathoner plugin, please? Especially selecting duplicate/non-orthogonal buildings. I'm not a macOS user, so I can't do it myself. Thanks a lot.
vorpalblade77-kaart
qeef: Works for me.
qeef
Thanks a lot. I've some bug report about JOSM request to disable the plugin when updated. However, I'm not able to replicate it on Linux with the latest/stable JOSM.
But it's to early to guess the problem.
I'm waiting for more info.
Thanks for testing.
vorpalblade77-kaart
https://josm.openstreetmap.de/ticket/20614 ? You might have to bump the minimum JOSM version to at least 17565.

#20614 ("Select Duplicate Buildings" tool in the Mapathoner plug-in does not work) – JOSM
Search: Login Preferences Help/Guide About Trac Register Forgot your password? Wiki Timeline Changelog Browse Source View Tickets New Ticket Roadmap
It looks like https://josm.openstreetmap.de/ticket/20363#comment:8

#20363 ([PATCH] Extract necessary method for QuadBuckets into separate interface) – JOSM
Search: Login Preferences Help/Guide About Trac Register Forgot your password? Wiki Timeline Changelog Browse Source View Tickets New Ticket Roadmap
Technically, a recompile should do it. But I'm not certain why I'm not seeing it (I'm running JOSM svn).
Also, they were using mapathoner 1.1.6 instead of the current latest 1.1.8.
Looking at https://gitlab.com/qeef/mapathoner/-/blob/master/build.gradle , it appears you are using 'tested' as the JOSM compile version. You can probably close the bug as fixed.

build.gradle · master · Jiri Vlasak / mapathoner - GitLab
GitLab.com
qeef
Yes, thanks, you are soo faster than me :D
Looks like it works with the latest stable.
vorpalblade77-kaart
Yep. It was a binary compatibility issue. I changed an interface to make it easier to reuse QuadBuckets for other geographical things besides IPrimitives. But all that was required to fix crashes was a recompile. @gri
grischard ran into that at the time the patch got pulled in.
qeef
Ok, thanks for explanation. And for really quick help with the debugging. Thanks!
vorpalblade77-kaart
No problem.