Download a relation object doesn't load members even if the box is checked

[anonymous]

What steps will reproduce the problem?

1. Select download object (ctrl+shift+O)
2. Select Object type = relation and its Object ID = ID (eg route master)
3. Select Download relation members
4. Click on Download object button

What is the expected result?

Route master and its route members are downloaded

What happens instead?

Only the route master is downloaded, not its members.

Please provide any additional information below. Attach a screenshot if possible.

I have to edit the relation to download its child members (third tab)

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Build-Date:2020-12-30 02:30:55
Revision:17428
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17428 fr) Linux Debian GNU/Linux 9.13 (stretch)
Memory Usage: 909 MB / 1820 MB (376 MB allocated, but free)
Java version: 1.8.0_275-8u275-b01-1~deb9u1-b01, Oracle Corporation, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600×900 (scaling 1,00×1,00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Desktop environment: KDE
Java package: openjdk-8-jre:amd64-8u275-b01-1~deb9u1
WebStart package: icedtea-netx:amd64-1.6.2-3.1+deb9u1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-13+deb9u1
Environment variable LANG: fr_FR.UTF-8
libcommons-logging-java: libcommons-logging-java:all-1.2-1
fonts-noto: fonts-noto:all-20161116-1
VM arguments: [-Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/bin/javaws, -Djava.security.manager, -Djava.security.policy=/etc/icedtea-web/javaws.policy]
Dataset consistency test: No problems found

Plugins:
+ FixAddresses (35640)
+ apache-commons (35524)
+ conflation (0.6.6)
+ ejml (35458)
+ geotools (35458)
+ gson (35458)
+ jaxb (35543)
+ jts (35458)
+ osm-obj-info (56)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35688)
+ scripting (30798)
+ todo (30306)
+ undelete (35640)
+ utilsplugin2 (35691)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Community_Centre&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PoliceFR&zip=1

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/FrenchEPCI&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip

[skyper]

Do you mean that relations are not downloaded recursively, e.g. the members of the child relations (route) are not downloaded?

Downloading members of a relation is possible from several panels in the context menu and within the relation dialog, so no need for a change.

[GerdP]

For a short time this method did a full recursive download. This was causing trouble with complex boundary relations and was thus reverted. See #18835

[anonymous]

@skyper: Yes, I know how to do it, I said it. I know how to do several additional operations to replace what was done in one go before.

@GerdP: So why keep the option to do it in the dialog windows (box)?

[GerdP]

Seems you don't see the difference between a download of members and the full recursive download. In the latter case the program will download members of sub relations until all members are complete. In your example you should find the complete master relation but not complete members of this master.

[anonymous]

@GendP: right, I did not think recursively enough. I find it regrettable to remove a feature rather than alerting contributors to the risks of using it, even if it is for their own good.

[skyper]

How about an additional suboption of "Download relation members", Recursively download child relations' members, to download recursively to the bottom?

Replying to skyper:

Downloading members of a relation is possible from several panels in the context menu and within the relation dialog, so no need for a change.

Sorry, my wording was off. I wanted to say that you do not need to modify the relation but you probably meant to open the relation editor to download the members and not to edit the relation.

[anonymous]

Replying to skyper:

How about an additional suboption of "Download relation members", Recursively download child relations' members, to download recursively to the bottom?

Maybe it's a not so bad alternative.

Sorry, my wording was off. I wanted to say that you do not need to modify the relation but you probably meant to open the relation editor to download the members and not to edit the relation.

You're right, of course! Whatever you want to do (to edit or to download members of the members), you have to open the relation editor...

[GerdP]

-1 You can download the members of a relation with a right click on the relation, no need to open the relation editor.

[anonymous]

Replying to GerdP:

-1 You can download the members of a relation with a right click on the relation, no need to open the relation editor.

TIL another tips&tricks on JOSM. Thx. That will be a substitute.

[skyper]

Replying to skyper:

Downloading members of a relation is possible from several panels in the context menu and within the relation dialog, so no need for a change.

Replying to anonymous:

Replying to GerdP:

-1 You can download the members of a relation with a right click on the relation, no need to open the relation editor.

TIL another tips&tricks on JOSM. Thx. That will be a substitute.

That's what I wrote in my first reply. Does work at least from tags/memberships, selection and relation panel.