Modify

Opened 4 years ago

Closed 3 years ago

#20585 closed defect (fixed)

Buildings tool doesn't update cursor icon when switching between building shapes

Reported by: Solarspot Owned by: Solarspot
Priority: minor Milestone:
Component: Plugin buildings_tools Version:
Keywords: template_report Cc:

Description (last modified by Solarspot)

What steps will reproduce the problem?

  1. Activate buildings mode (B)
  2. Switch between rectangular and circular buildings ((Alt+R, Alt+Z)

What is the expected result?

Cursor icon should change accordingly

What happens instead?

Icon stays the same until the mouse is moved, then it updates.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Revision:17428
Build-Date:2020-12-29 02:30:53
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17428 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 387 MB / 2048 MB (300 MB allocated, but free)
Java version: 9.0.4+11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 2560×1440 (scaling 1,00×1,00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→32×32, 32×32→32×32

Plugins:
+ FastDraw (35640)
+ ImproveOsm (203)
+ OpeningHoursEditor (35640)
+ QuickLabel (18)
+ RoadSigns (35640)
+ SimplifyArea (35640)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35690)
+ contourmerge (v0.1.6)
+ editgpx (35562)
+ imagery_offset_db (35640)
+ jaxb (35543)
+ jna (35662)
+ merge-overlap (35640)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ rasterfilters (35648)
+ routes (35543)
+ tageditor (35640)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35691)
+ wikipedia (1.1.4)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/CommonKeyboardShortcuts&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/public_bookcase&zip=1
+ %UserProfile%\Desktop\xmas.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Healthcare&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://github.com/hotosm/HDM-JOSM-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- %UserProfile%\Downloads\Styles_Coloured_buildings\Styles_Coloured_buildings-style.zip

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingStreetnumberOrConscriptionnumber&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
+ https://www.openrailwaymap.org/validator/de-openrailwaymap.validator.mapcss
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss
+ https://raw.githubusercontent.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss
+ https://github.com/Jungle-Bus/transport_mapcss/raw/master/transport.validator.zip

Last errors/warnings:
- 00009,143 W: Failed to scan file 'public_transport_layer.jar.new' for plugin information. Skipping.
- 00009,696 W: Failed to install plugin '<josm.pref>\plugins\public_transport_layer.jar' from temporary download file '<josm.pref>\plugins\public_transport_layer.jar.new'. zip file is empty: java.util.zip.ZipException: zip file is empty
- 00014,720 W: Failed to open file with extension 'mapcss' and namepart 'style' in zip file 'Styles_Coloured_buildings-style.zip'. Exception was: java.nio.file.NoSuchFileException: %UserProfile%\Downloads\Styles_Coloured_buildings\Styles_Coloured_buildings-style.zip: java.nio.file.NoSuchFileException: %UserProfile%\Downloads\Styles_Coloured_buildings\Styles_Coloured_buildings-style.zip
- 00015,315 W: Failed to load Mappaint styles from '%UserProfile%\Downloads\Styles_Coloured_buildings\Styles_Coloured_buildings-style.zip'. Exception was: java.nio.file.NoSuchFileException: %UserProfile%\Downloads\Styles_Coloured_buildings\Styles_Coloured_buildings-style.zip
- 00015,315 E: java.nio.file.NoSuchFileException: %UserProfile%\Downloads\Styles_Coloured_buildings\Styles_Coloured_buildings-style.zip
- 00016,808 E: java.nio.file.NoSuchFileException: %UserProfile%\Desktop\xmas.xml
- 00016,808 E: %UserProfile%\Desktop\xmas.xml
- 00017,737 W: java.io.IOException: The requested URL https://github.com/Jungle-Bus/transport_mapcss/raw/master/transport.validator.zip was not found
- 00017,877 W: Failed to add https://github.com/Jungle-Bus/transport_mapcss/raw/master/transport.validator.zip to tag checker
- 00017,879 W: java.io.IOException: No file found for: https://github.com/Jungle-Bus/transport_mapcss/raw/master/transport.validator.zip

Attachments (0)

Change History (5)

comment:1 by Solarspot, 4 years ago

Description: modified (diff)

comment:2 by Solarspot, 4 years ago

Owner: changed from Upliner to Solarspot

comment:3 by Solarspot, 4 years ago

Summary: Buildings tool does't update cursor icon when switching between building shapesBuildings tool doesn't update cursor icon when switching between building shapes

comment:4 by Solarspot, 4 years ago

In ticket #20564 there is a patch that also fixes this bug: https://josm.openstreetmap.de/attachment/ticket/20564/20564_and_20585.patch

comment:5 by GerdP, 3 years ago

Resolution: fixed
Status: newclosed

In 35740/osm:

fix #20564 and #20585: Buildings tool shows wrong cursor icon
patch 20564_and_20585.patch (modified) by Solarspot

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Solarspot.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.