Some weird crash in the middle of exporting photos with Mapillary plugin

[mrgenie@…]

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-02-24 00:40:01 +0100 (Wed, 24 Feb 2021)
Build-Date:2021-02-24 02:30:57
Revision:17538
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17538 en) Windows 10 64-Bit
OS Build number: Windows 10 Home Single Language 2009 (19042)
Memory Usage: 1868 MB / 1868 MB (168 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 3840×2160 (scaling 1.00×1.00)
Maximum Screen Size: 3840×2160
Best cursor sizes: 16×16→32×32, 32×32→32×32
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.37.2)
+ apache-commons (35524)
+ apache-http (35589)
+ jna (35662)
+ undelete (35640)

Tagging presets:
+ <josm.pref>\Phillipines_Jeepney\Phillipines_Jeepney.xml

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
+ %UserProfile%\Documents\elemstyles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/ColourGPSData&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1

Last errors/warnings:
- 02193.908 E: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketTimeoutException: Read timed out
- 02193.908 E: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 02193.908 E: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 03014.640 W: java.net.SocketTimeoutException: connect timed out
- 03014.642 W: Already here java.net.SocketTimeoutException: connect timed out
- 03014.643 W: java.net.SocketTimeoutException: connect timed out
- 09157.504 W: java.net.SocketTimeoutException: connect timed out
- 81903.214 E: Thread main-worker-0 raised java.lang.OutOfMemoryError: Java heap space
- 81903.227 E: Handled by bug report queue: java.lang.OutOfMemoryError: Java heap space
- 81903.250 E: Handled by bug report queue: org.openstreetmap.josm.gui.progress.ProgressException: Expected states are [IN_TASK, IN_SUBTASK] but current state is FINISHED



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: Thread-60 (4022)
org.openstreetmap.josm.gui.progress.ProgressException: Expected states are [IN_TASK, IN_SUBTASK] but current state is FINISHED
	at org.openstreetmap.josm.gui.progress.AbstractProgressMonitor.checkState(AbstractProgressMonitor.java:84)
	at org.openstreetmap.josm.gui.progress.AbstractProgressMonitor.internalUpdateProgress(AbstractProgressMonitor.java:266)
	at org.openstreetmap.josm.gui.progress.AbstractProgressMonitor.setTicks(AbstractProgressMonitor.java:244)
	at org.openstreetmap.josm.gui.progress.AbstractProgressMonitor.worked(AbstractProgressMonitor.java:258)
	at org.openstreetmap.josm.plugins.mapillary.io.export.MapillaryExportWriterThread.run(MapillaryExportWriterThread.java:142)

[skyper]

Replying to mrgenie@…:

Memory Usage: 1868 MB / 1868 MB (168 MB allocated, but free)

Last errors/warnings:
- 81903.214 E: Thread main-worker-0 raised java.lang.OutOfMemoryError: Java heap space
- 81903.227 E: Handled by bug report queue: java.lang.OutOfMemoryError: Java heap space
- 81903.250 E: Handled by bug report queue: org.openstreetmap.josm.gui.progress.ProgressException: Expected states are [IN_TASK, IN_SUBTASK] but current state is FINISHED

It looks like, JOSM did run out of memory. You need to give JOSM more memory or load less data.

Anyway, there should be a warning dialog and not a crash.

[anonymous]

Yes, well it was really "unresponsive" for several minutes assuming that's a crash thus I eventually killed it in the task manager.

The thing is, loading photos in the photolayer ~ 1GB
Then importing in Mapillary layer 1GB

Then removing the photo layer, i assume that frees up the 1GB from that layer, but it doesn't.

That's basically why it ruined my work. Didn't free uo properly.

[taylor.smock]

As far as this goes, I'd have to look at why my fix for #20504 is causing this #20550 (my fix for #20550 was setting the queue sizes to the number of images that were being exported).

Anyway, a workaround is to not export a bunch of images from the Mapillary service. I've just made some recent modifications which may help, but it isn't something I can afford to spend a lot of time on right now (sorry).

See ​https://blog.mapillary.com/update/2021/03/03/preparing-for-the-new-mapillary-api.html for why.

[taylor.smock]

I think I fixed this (not yet released).

Let me know if this is still a problem after I make a release (probably tomorrow, will require josm-latest, not josm-tested.