Modify

Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#20528 closed defect (fixed)

Cannot copy from the welcome screen

Reported by: richlv Owned by: team
Priority: normal Milestone: 22.12
Component: Core Version: tested
Keywords: copy startup page Cc:

Description

In the welcome screen (the one with "News", "Getting Started" and "Getting Help"), text can be selected, upon right-click "Copy" is available, but clipboard contents are not updated.

Would be great to be able to copy from this screen (menu, keyboard shortcut, context menu).

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Build-Date:2020-12-30 02:30:55
Revision:17428
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17428 en_GB) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H524)
Memory Usage: 913 MB / 1820 MB (795 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1127230987 1920×1080 (scaling 1.00×1.00) Display 69733382 1680×1050 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
VM arguments: [-Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlp.tk=awt, -Djnlpx.jvm=<java.home>/bin/java, -Djnlpx.splashport=-1, -Djnlpx.home=<java.home>/bin, -Djnlpx.remove=false, -Djnlpx.offline=false, -Djnlpx.relaunch=true, -Djnlpx.session.data=/var/folders/nl/flqxqsmj5q963r7tcnfrdt3c0000gn/T/session862033085999899560, -Djnlpx.heapsize=-1,2147483648, -Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.origFilenameArg=/Users/richlv/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-72e8e992, -Dsun.awt.warmup=true, -Djava.security.manager]

Plugins:
+ InfoMode (35543)
+ Mapillary (1.5.36.3)
+ PicLayer (2a9aa7a)
+ apache-commons (35524)
+ apache-http (35589)
+ ejml (35458)
+ geotools (35458)
+ imagery_offset_db (35640)
+ javafx-osx (35655)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ pbf (35650)
+ photo_geotagging (35640)
+ reverter (35688)
+ utilsplugin2 (35691)

Map paint styles:
- /Users/richlv/Desktop/ChangeFontSize.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 00009.456 W: Failed to load Mappaint styles from '/Users/richlv/Desktop/ChangeFontSize.mapcss'. Exception was: java.nio.file.NoSuchFileException: /Users/richlv/Desktop/ChangeFontSize.mapcss
- 00009.457 E: java.nio.file.NoSuchFileException: /Users/richlv/Desktop/ChangeFontSize.mapcss

Attachments (0)

Change History (7)

in reply to:  description comment:1 by Don-vip, 4 years ago

Replying to richlv:

upon right-click "Copy" is available, but clipboard contents are not updated.

Only from the welcome screen? If you use copy from right click menu somewhere else, it works?

comment:2 by richlv, 4 years ago

Yes, that works elsewhere (like dialogs).
Also the menu entry Edit -> Copy is greyed out in the welcome screen, possibly related to the inability to copy text.

comment:3 by skyper, 4 years ago

Keywords: copy startup page added
Summary: Mac: Cannot copy from the welcome screenCannot copy from the welcome screen

Does not work for me neither. Context menu offers two actions ("Copy" and "Select all"), both enabled, but "Copy" does not work. Luckily, middle mouse button copy works, so not a big issue for me.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-03-01 23:51:35 +0100 (Mon, 01 Mar 2021)
Revision:17551
Build-Date:2021-03-02 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17551 en) Linux Debian GNU/Linux 10 (buster)
Java version: 11.0.9.1+1-post-Debian-1deb10u2, Debian, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarkLaf

comment:4 by Solarspot, 4 years ago

I've tested old JOSM versions and found out that the issue exists since josm-snapshot-10647.jar. It came with the patch for #13196: the TransferHandler was set to null in GettingStarted.java.

 	127	        lg.setTransferHandler(null);

If I remove this line, "Copy" works again but drag-and-drop of files into JOSM window doesn't work anymore. Don't know how to solve it.

comment:5 by taylor.smock, 2 years ago

Resolution: fixed
Status: newclosed

In 18601/josm:

Fix #20528: Copy does not work from the welcome screen

This was caused by setting the TransferHandler to null in order to get
drag and drop working. Instead of setting the TransferHandler to null, we
just set the DropTarget to null, which is what prevents the parent
DropTarget from being triggered.

The DropTarget could also have it's setActive method called with false,
but this will hopefully be less surprising.

comment:6 by taylor.smock, 2 years ago

Milestone: 22.11

comment:7 by taylor.smock, 2 years ago

Milestone: 22.1122.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.