Modify

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#20493 closed enhancement (fixed)

Contribute to changeset discussion directly in JOSM

Reported by: habi Owned by: Don-vip
Priority: normal Milestone: 21.02
Component: Core Version:
Keywords: template_report changeset discussion comment Cc:

Description

What steps will reproduce the problem?

  1. Load a changeset (for example with https://josm.openstreetmap.de/wiki/Help/Dialog/ChangesetManager)
  2. Comment on the changeset directly in JOSM without loading the changeset in the browser

What is the expected result?

Commenting on a changeset is possible to do in JOSM.

What happens instead?

Commenting seems not to be possible, even though it should, according to simon04 in the #josm matrix chat: https://matrix.to/#/!LzhExwiqAnBnpnsLJk:matrix.org/$161315339664347rrJMw:matrix.org?via=matrix.org&via=grin.hu

Please provide any additional information below. Attach a screenshot if possible.

Revision:17428
Is-Local-Build:true
Build-Date:2020-12-30 15:56:02

Identification: JOSM/1.5 (17428 SVN en_GB) Mac OS X 10.16
OS Build number: macOS 11.2 (20D64)
Memory Usage: 500 MB / 8192 MB (218 MB allocated, but free)
Java version: 15.0.1+9, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69734272 1440×900 (scaling 2.00×2.00)
Maximum Screen Size: 1440×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
VM arguments: [--module-path=/Applications/JOSM.app/Contents/app/mods]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35640)
+ Mapillary (1.5.36.4)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35669)
+ javafx-osx (35655)
+ jna (35662)
+ mapathoner (1.1.5)
+ terracer (35640)

Tagging presets:
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip

Last errors/warnings:
- 00034.423 E: Failed to locate image 'object--wire-group'
- 00034.516 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00035.099 E: Failed to locate image 'regulatory--texts--g1'
- 00035.100 E: Failed to locate image 'regulatory--texts--g2'
- 00035.201 E: Failed to locate image 'void--car-mount'
- 00035.201 E: Failed to locate image 'void--dynamic'
- 00035.202 E: Failed to locate image 'void--ego-vehicle'
- 00035.202 E: Failed to locate image 'void--ground'
- 00035.202 E: Failed to locate image 'void--static'
- 00035.334 E: Failed to locate image 'warning--kangaroo-crossing--g1'

Attachments (0)

Change History (6)

comment:1 Changed 11 months ago by Don-vip

Keywords: changeset discussion comment added

comment:2 Changed 11 months ago by Don-vip

Milestone: 21.02
Owner: changed from team to Don-vip
Status: newassigned

comment:3 Changed 11 months ago by Don-vip

In 17500/josm:

see #20493 - add initial support to comment changesets directly from JOSM

Doesn't seem to work yet, server always answer HTTP 401 even if OAuth authorization headers are set?

comment:4 Changed 11 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 17506/josm:

fix #20493 - allow to comment changesets directly from JOSM

comment:5 Changed 11 months ago by habi

Thanks for the quick fix, looking forward to test it soon!

comment:6 Changed 11 months ago by habi

Works very nicely with Version 17542: https://www.openstreetmap.org/changeset/71302273

Again, thanks a bunch!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.