Modify

Opened 16 months ago

Closed 13 months ago

Last modified 13 months ago

#20444 closed enhancement (fixed)

[Patch] Provide an "informal" checkbox in the "path" preset

Reported by: pch14@… Owned by: team
Priority: normal Milestone: 21.04
Component: Internal preset Version:
Keywords: informal path Cc:

Description

Openstreetmap data contains many dirt trails that neither are officially created nor maintained. They are also known as desire paths in England. In German they are best called "Trampelpfad". The key is quite old, but only recently the practice of marking paths "informal=yes" has become widespread and certainly many JOSM users are already doing that too.

Would be nice to have that as a check box in the path panel, eg. right after "segregated"?
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/defaultpresets.xml#L1096

Also the autocomplete for adding tags to entities should learn about it.

Attachments (2)

josm_20444_informal.patch (1.9 KB) - added by skyper 13 months ago.
patch adding a check
josm_20444_multirow_checkgroup.patch (906 bytes) - added by skyper 13 months ago.
revert part and use one checkgroup as #20792 was fixed

Download all attachments as: .zip

Change History (11)

comment:1 Changed 16 months ago by skyper

Component: CoreInternal preset
Keywords: informal path added

Changed 13 months ago by skyper

Attachment: josm_20444_informal.patch added

patch adding a check

comment:2 Changed 13 months ago by skyper

Summary: Provide an "informal" checkbox in the "path" preset[Patch] Provide an "informal" checkbox in the "path" preset

Please, find attached patch which adds the check for informal=yes and removes some duplication in chunks.

comment:3 Changed 13 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17817/josm:

fix #20444 - Add informal=yes checkbox to highway=path preset (patch by skyper)

comment:4 Changed 13 months ago by Klumbumbus

Milestone: 21.04

comment:5 Changed 13 months ago by pch14@…

Thank you a lot!

comment:6 Changed 13 months ago by skyper

Mmh, with #20792 fixed we might want to revert part of my patch concerning the chunk:

	    <chunk id="highway_yesno_incline_oneway_lit_width">
 	        <checkgroup columns="4">
 	            <check key="bridge" text="Bridge" disable_off="true" />
 	            <check key="tunnel" text="Tunnel" disable_off="true" />
 	            <check key="embankment" text="Embankment" disable_off="true" />
 	            <check key="cutting" text="Cutting" disable_off="true" />
	            <check key="oneway" text="Oneway" />
	            <check key="lit" text="Lit" />
 	        </checkgroup>
	        <combo key="incline" text="Incline" values="10%,-10%,10°,-10°,up,down" />
	        <text key="width" text="Width (meters)" />
	    </chunk>

should display better now instead of two checkgroups.

Changed 13 months ago by skyper

revert part and use one checkgroup as #20792 was fixed

comment:7 Changed 13 months ago by skyper

Resolution: fixed
Status: closedreopened

Find attached patch which changes the chunk to one checkgroup as, since r17829, this should gives a better looking result in alignment.

comment:8 Changed 13 months ago by simon04

Resolution: fixed
Status: reopenedclosed

In 17833/josm:

fix #20444 - One checkgroup for highway=path preset (patch by skyper)

comment:9 Changed 13 months ago by skyper

Thanks

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.