Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20438 closed enhancement (fixed)

Validator: warn about zoo without tourism=zoo

Reported by: Famlam Owned by: Don-vip
Priority: normal Milestone: 21.02
Component: Core validator Version: tested
Keywords: template_report zoo tourism Cc:


What steps will reproduce the problem?

  1. Validate a node with zoo=petting_zoo without tourism=zoo.

What is the expected result?

Warning: zoo without tourism=zoo

What happens instead?

No warning.

Please provide any additional information below. Attach a screenshot if possible.

About 1500 zoo's are mapped without tourism=zoo, even though it's a required key combination. A possible fix would be:

*[zoo][tourism!=zoo] {
  throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
  group: tr("missing tag");
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Build-Date:2020-12-29 02:30:53
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17428 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 798 MB / 1820 MB (624 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel:
Screen: \Display0 1920×1080 (scaling 1,00×1,00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32

+ OpeningHoursEditor (35640)
+ SimplifyArea (35640)
+ imagery_offset_db (35640)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35640)
+ tageditor (35640)
+ turnlanes-tagging (288)
+ undelete (35640)
+ utilsplugin2 (35674)

Map paint styles:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Last errors/warnings:
- 00009,149 W: Expecting test '{0.key} zonder {1.tag}' (i.e., [node[zoo][tourism'NEQ'zoo], way[zoo][tourism'NEQ'zoo]:closed]) to match way zoo=petting_zoo (i.e., TagMap[zoo=petting_zoo])

Attachments (0)

Change History (5)

comment:1 by Don-vip, 3 years ago

Keywords: tourism added
Milestone: 21.01

comment:2 by Don-vip, 3 years ago

Owner: changed from team to Don-vip
Status: newassigned

comment:3 by Don-vip, 3 years ago

Resolution: fixed
Status: assignedclosed

In 17480/josm:

fix #20438 - warn about zoo without tourism=zoo (patch by Famlam)

comment:4 by Don-vip, 3 years ago

thank you for this very nice ticket!

comment:5 by stoecker, 3 years ago

Milestone: 21.0121.02

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.