Modify ↓
Opened 3 years ago
Last modified 3 years ago
#20424 assigned defect
Duplicate relations not detected with incomplete members
| Reported by: | skyper | Owned by: | GerdP |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core validator | Version: | latest |
| Keywords: | template_report duplicate relations | Cc: |
Description
What steps will reproduce the problem?
- Have a relation without members downloaded
- Duplicate relation and click on ok in relation editor
- Run Validator
What is the expected result?
Error: Duplicated relations
What happens instead?
No error
Please provide any additional information below. Attach a screenshot if possible.
It does only work if the members are downloaded.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-01-22 10:21:26 +0100 (Fri, 22 Jan 2021) Revision:17475 Build-Date:2021-01-23 02:30:52 URL:https://josm.openstreetmap.de/svn/trunk
Attachments (1)
Change History (6)
comment:1 Changed 3 years ago by
Changed 3 years ago by
| Attachment: | 20424.patch added |
|---|
simple approach which may produce duplicate error messages
comment:2 Changed 3 years ago by
| Milestone: | → 21.02 |
|---|---|
| Owner: | changed from team to GerdP |
| Status: | new → assigned |
The attached patch works for your case but doesn't pass the unit tests and produces duplocate error messages for complete relations, so it's not such a simple change.
comment:5 Changed 3 years ago by
| Milestone: | 21.03 |
|---|
Note: See
TracTickets for help on using
tickets.
Yes, the algo doesn't just compare members, it calculates and compares the geometry of relations. Without members in cannot do that. I also expected a simple member list compare, but the algo is more complex. Your case could be added, though.