Modify

Opened 4 weeks ago

Closed 13 days ago

Last modified 13 days ago

#20289 closed defect (fixed)

[Patch] Unglue Node shows confusing "Where should the tags of the node be put" for node with converted_by=* tag

Reported by: GerdP Owned by: GerdP
Priority: normal Milestone: 21.01
Component: Core Version:
Keywords: template_report Cc: simon04

Description

What steps will reproduce the problem?

  1. Have a node that connects two or more ways and is tagged with converted_by=converted_byTrack2osm
  2. Select the node, note that JOSM doesn't show any tags for it
  3. press G to unglue

What is the expected result?

Node is unglued without confirmation dialog

What happens instead?

Josm asks "Where should the tags of the node be put"

Please provide any additional information below. Attach a screenshot if possible.

Probably happens with all tags that will be removed automatically. JOSM should not check if a node has tags but if they are relevant.

Build-Date:2020-12-23 16:58:42
Revision:17425
Is-Local-Build:true

Identification: JOSM/1.5 (17425 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 824 MB / 1792 MB (373 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→48×48, 32×32→48×48
Dataset consistency test: No problems found

Plugins:
+ apache-commons (35524)
+ buildings_tools (35669)
+ continuosDownload (91)
+ ejml (35458)
+ geotools (35458)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ measurement (35640)
+ o5m (35640)
+ opendata (35640)
+ pbf (35650)
+ poly (35640)
+ reverter (35640)
+ undelete (35640)
+ utilsplugin2 (35674)

Attachments (1)

20289.patch (1.3 KB) - added by GerdP 3 weeks ago.

Download all attachments as: .zip

Change History (7)

Changed 3 weeks ago by GerdP

Attachment: 20289.patch added

comment:1 Changed 3 weeks ago by GerdP

Milestone: 20.12
Owner: changed from team to GerdP
Status: newassigned
Summary: Unglue Node shows confusing "Where should the tags of the node be put" for node with converted_by=* tag[Patch] Unglue Node shows confusing "Where should the tags of the node be put" for node with converted_by=* tag

Patch implements two changes:
1) don't show the dialog for confirmation if node has only "uninteresting" tags
2) remove the tags in the cloned nodes if all are "uninteresting"

Will add a unit test for this...

comment:2 Changed 3 weeks ago by GerdP

Cc: simon04 added

@Simon: The code was introduced with r9292. Did you intend to show the dialog for uninteresting keys? If yes, we should find a better way to show them to the user, else my patch should be fine.

comment:3 Changed 3 weeks ago by GerdP

Hm, I have no idea how to write a unit test that checks if a popoup was shown or not, and there is no unit test for this up to now. So, I'll just commit the patch.

Last edited 3 weeks ago by GerdP (previous) (diff)

comment:4 Changed 3 weeks ago by GerdP

Milestone: 20.12

I just noticed (again) that isTagged() ignores many more tags, not just those returned by getDiscardableKeys(). I'll think again about this...

comment:5 Changed 13 days ago by GerdP

Resolution: fixed
Status: assignedclosed

In 17438/josm:

fix #20289: Unglue Node shows confusing "Where should the tags of the node be put" for node with converted_by=* tag

  • check isTagged() instead of hasKeys() like in other methods

comment:6 Changed 13 days ago by GerdP

Milestone: 21.01

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.