Modify

Opened 3 months ago

Last modified 3 months ago

#20245 new enhancement

Simplify login panel, especially for people without expert mode enabled

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Reset JOSM settings and do not enable "expert mode"
  2. Make edit
  3. Upload anything

What is the expected result?

You have a login screen understandable to a normal person (OK, normal among trying to use JOSM).

What happens instead?

"Please select an authorization procedure" dropdown that is

  • confusing (I am a programmer, extremely advanced OSM mapper and I have no clue what would actually change if I would use it)
  • misleading (selecting is not necessary, default is fine)
  • not needed (?) - is it even needed for a normal person?
  • distracting - with massive amount of things on this window it is hard to find where I am supposed to input credentials

Recommendation:

  • disable outside expert mode
  • even in expert mode move to Advanced OAuth properties tab
  • change text to "authorization procedure mode" or something that is not suggesting that using dropdown is needed (probably not needed if it was moved to advanced settings tab)

"Granted rights" is kind of pointless especially for newbie.

  • if one runs program on their PC and gives them credentials, then I need to trust it anyway
  • newbie is either not going to use it or disable something and later be confused
  • distracting from main point of login screen

Recommendation:

  • disable outside expert mode

Advanced OAuth properties tab - it really should be disabled outside expert mode

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-25 13:40:57 +0100 (Wed, 25 Nov 2020)
Revision:17360
Build-Date:2020-11-26 02:30:53
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17360 en_GB) Linux Ubuntu 20.04.1 LTS
Memory Usage: 198 MB / 976 MB (44 MB allocated, but free)
Java version: 11.0.9.1+1-Ubuntu-0ubuntu1.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.9.1+1-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
Environment variable LANG: en_GB.UTF-8
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Last errors/warnings:
- 00183.329 W: Unsupported match type class org.openstreetmap.josm.data.osm.search.SearchCompiler$Any: addr:place
- 00308.226 W: Unsupported match type class org.openstreetmap.josm.data.osm.search.SearchCompiler$Any: addr:place
- 00336.804 W: Unsupported match type class org.openstreetmap.josm.data.osm.search.SearchCompiler$Any: aaaa
- 00346.095 W: Unsupported match type class org.openstreetmap.josm.data.osm.search.SearchCompiler$Any: tag
- 00992.493 E: org.openstreetmap.josm.io.MissingOAuthAccessTokenException
- 00992.608 E: Authentication failed - <html>Failed to authenticate at the OSM server 'https://api.openstreetmap.org/api'.<br>You are using OAuth to authenticate but currently there is no<br>OAuth Access Token configured.<br>Please open the Preferences dialogue and generate or enter an Access Token.</html>
- 01044.104 E: org.openstreetmap.josm.io.MissingOAuthAccessTokenException
- 01044.200 E: Authentication failed - <html>Failed to authenticate at the OSM server 'https://api.openstreetmap.org/api'.<br>You are using OAuth to authenticate but currently there is no<br>OAuth Access Token configured.<br>Please open the Preferences dialogue and generate or enter an Access Token.</html>

Attachments (2)

screen.png (36.1 KB) - added by mkoniecz 3 months ago.
first screen
screen01.png (40.3 KB) - added by mkoniecz 3 months ago.
second screen

Download all attachments as: .zip

Change History (5)

Changed 3 months ago by mkoniecz

Attachment: screen.png added

first screen

comment:1 Changed 3 months ago by mkoniecz

And even more:

after login you get second screen. I propose to make following modifications:

Do not explicitly ask people to accept token. What is the usecase for giving credentials and rejecting OAuth token on the second screen? It seems that it will be done solely by people confused by the process.

1) run "test access token" automatically as a part of authorization procedure and on success show "JOSM authorized" or something, maybe with "show details" button that would open current second screen.

Do not show "save access token in preferences" toggle for people without expert mode.

Again, hide authorization procedure dropdown outside expert mode.

Also, why access token secret is shown at all? I see no use for displaying it. It is just troublesome for people making JOSM tutorial video, streaming, or making some workshop that shows their screen. (I almost uploaded the screenshot with my secret token right now).

Last edited 3 months ago by mkoniecz (previous) (diff)

comment:2 Changed 3 months ago by mkoniecz

Description: modified (diff)

Changed 3 months ago by mkoniecz

Attachment: screen01.png added

second screen

comment:3 Changed 3 months ago by mkoniecz

Overall I think that it is worth improving as it is part of the first contact with JOSM and this is confusing without a good reason and confusion may be reduced by simply deleting and hiding parts of interface.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to mkoniecz
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.