Opened 4 years ago

Closed 4 years ago

#20230 closed defect (fixed)

update multipolygon action removes tags from ways without adding them to relation

Reported by: GerdP Owned by: GerdP
Priority: major Milestone: 20.12
Component: Core Version: latest
Keywords: template_report multipolygon regression Cc:

Description (last modified by GerdP)

What steps will reproduce the problem?

  1. Create new relation and add tag type=multipolygon
  2. Select the new relation and a building way
  3. Use Ctrl+Shift+B to update the multipolygon

What is the expected result?

tags from way are removed from the way and added to the relation

What happens instead?

tags from way are removed from the way and not added to the relation

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2020-12-12 14:42:33

Identification: JOSM/1.5 (17402 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 767 MB / 1820 MB (371 MB allocated, but free)
Java version: 1.8.0_272-b10, AdoptOpenJDK, OpenJDK 64-Bit Server VM
Look and Feel:
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:57586, -ea, -javaagent:D:\eclipse-java-2020-09\eclipse\configuration\org.eclipse.osgi\215\0\.cp\lib\javaagent-shaded.jar, -Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

+ ColumbusCSV (35640)
+ buildings_tools (35669)
+ o5m (35640)
+ pbf (35650)
+ poly (35640)
+ reltoolbox (35640)
+ reverter (35640)
+ undelete (35640)
+ utilsplugin2 (35671)

Validator rules:
+ c:\josm\core\resources\data\validator\geometry.mapcss

Attachments (0)

Change History (3)

comment:1 by GerdP, 4 years ago

Description: modified (diff)
Owner: changed from team to GerdP
Status: newassigned

comment:2 by GerdP, 4 years ago

Keywords: regression added

regression of r17358

comment:3 by GerdP, 4 years ago

Resolution: fixed
Status: assignedclosed

In 17406/josm:

fix #20230: update multipolygon action removes tags from ways without adding them to relation

  • create ChangeCommand if tags of updated relation were changed

Todo: refactoring to remove class CreateUpdateMultipolygonTask

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.