Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#20222 closed defect (fixed)

Relation editor: Changes in member order are lost when updates are applied

Reported by: skyper Owned by: GerdP
Priority: major Milestone: 20.12
Component: Core Version: latest
Keywords: template_report regression relation editor apply change Cc:

Description

What steps will reproduce the problem?

  1. Open a route relation in relation editor
  2. Select some members and move them up in memberlist
  3. Delete or add a tag of the relation still in relation editor
  4. Apply the current updates

What is the expected result?

All change are applied

What happens instead?

Only changes of tags are applied and the changes in member order are lost.

Please provide any additional information below. Attach a screenshot if possible.

This can destroy a lot of work and might not be noticed by the user.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-10 17:38:18 +0100 (Thu, 10 Dec 2020)
Revision:17400
Build-Date:2020-12-11 02:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (4)

comment:1 Changed 5 weeks ago by skyper

Summary: Relation editor: Changes in member order are lost when changes are appliedRelation editor: Changes in member order are lost when updates are applied

comment:2 Changed 5 weeks ago by GerdP

Owner: changed from team to GerdP
Status: newassigned

Probably a regression from one of the changes for #19885

comment:3 Changed 5 weeks ago by GerdP

Resolution: fixed
Status: assignedclosed

In 17401/josm:

fix #20222: Relation editor: Changes in member order are lost when updates are applied

  • correct logic which decides what type of command is needed, regression from r17358

comment:4 Changed 5 weeks ago by GerdP

Milestone: 20.12

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.