Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20212 closed defect (worksforme)

Extrude action may add unexpected nodes

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Press X to switch to Extrude mode
  2. Select a segment of a building
  3. Move this segment to the inside of the building
  4. Move the same segment out again

What is the expected result?

Two nodes are moved in step 3 and 4

What happens instead?

Sometimes nodes are added to the building when steps 3 and 4 are repeated

Please provide any additional information below. Attach a screenshot if possible.

I cannot always reproduce this.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-21 14:56:29 +0100 (Sat, 21 Nov 2020)
Build-Date:2020-11-22 02:30:52
Revision:17329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17329 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 968 MB / 3641 MB (437 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20201208_102035.jfr]
Dataset consistency test: No problems found

Plugins:
+ ColumbusCSV (35640)
+ buildings_tools (35640)
+ o5m (35640)
+ pbf
+ poly (35640)
+ reltoolbox (35640)
+ reverter (35640)
+ terracer (35640)
+ undelete (35640)
+ utilsplugin2 (35640)

Validator rules:
+ c:\josm\core\resources\data\validator\geometry.mapcss

Last errors/warnings:
- 00007.622 W: Warning - <html>Plugin pbf requires JOSM version 17334. The current JOSM version is 17329.<br>You have to update JOSM in order to use this plugin.</html>

Attachments (0)

Change History (7)

comment:1 by GerdP, 3 years ago

I think it happens when the cursor is close to another segment when the dragging is stopped by releasing the mouse button, so, the more buildings there are the more likely this happens. The problem doesn't seem to occur when the Ctrl button is pressed.

Last edited 3 years ago by GerdP (previous) (diff)

comment:2 by GerdP, 3 years ago

OK, now I know how to reproduce:
When I chose the right side of the building for step 3 and move it back to the right in step 4 AND move the cursor also down so that it is below the building the nodes are added. This doesn't happen when the cursor is moved above, so it is probably not a feature but a bug.

comment:3 by skyper, 3 years ago

I cannot reproduce. Do you have an example object?

in reply to:  2 comment:4 by skyper, 3 years ago

Replying to GerdP:

OK, now I know how to reproduce:
When I chose the right side of the building for step 3 and move it back to the right in step 4 AND move the cursor also down so that it is below the building the nodes are added. This doesn't happen when the cursor is moved above, so it is probably not a feature but a bug.

Are you sure that your example object is orthogonal. There is a mode where the position of the mouse matters but only if you do not have an orthogonalized object.

comment:5 by GerdP, 3 years ago

I can reproduce it with w111843575. Select the right side, move it to the left and make sure the cursor is above the building before you release the mouse. Now move cursor to the middle of the segment and move it back near to the original position and make sure that the cursor is below the building when you release the mouse button.

comment:6 by skyper, 3 years ago

That way is not 100% orthogonal. If you use Orthogonalize Shape in advance it is fine.
I was able to get the same behavior to the bottom.
Watch the highlighting of the referenced side and the small square in the corner of a right angle.
If I move inside with the side highlighted and than outside with again this side highlighted I get the new nodes. As it only happens after moving inside it could be a rounding problem.

Last edited 3 years ago by skyper (previous) (diff)

comment:7 by GerdP, 3 years ago

Resolution: worksforme
Status: newclosed

OK, with a building that is clearly not orthogonal the effect is obvious. So, my fault, I didn't know this special case.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.