History popup doesn't appear

[ahoran@…]

What steps will reproduce the problem?

1. Open JOSM and download map data.
2. Select a way, and either press the History button, or CTRL-H
3. You will see a small dialogue indicating that it's retrieving changesets and history. It goes away after few seconds.

What is the expected result?

You expect the history popup to appear.

What happens instead?

No popup, no history.
No errors visible.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-21 14:56:29 +0100 (Sat, 21 Nov 2020)
Build-Date:2020-11-22 02:30:52
Revision:17329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17329 en_AU) Windows 10 64-Bit
OS Build number: Windows 10 Enterprise 2009 (19042)
Memory Usage: 247 MB / 989 MB (113 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) Client VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 3240x2160 (scaling 1.0x1.0), \Display1 3840x2160 (scaling 1.0x1.0)
Maximum Screen Size: 3840x2160
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32

Plugins:
+ imagery_offset_db (35640)
+ turnrestrictions (35640)

Last errors/warnings:
- 00012.716 W: java.nio.file.FileSystemException: %UserProfile%\AppData\Local\Temp\josm_exec_powershell_7788225004629836289.txt: The process cannot access the file because it is being used by another process.
- 00012.718 W: Unable to request certificate of https://grca.nat.gov.tw
- 00017.814 W: java.nio.file.FileSystemException: %UserProfile%\AppData\Local\Temp\josm_exec_powershell_2437750144721658623.txt: The process cannot access the file because it is being used by another process.
- 00017.815 W: Unable to request certificate of https://grca.nat.gov.tw

[GerdP]

Cannot reproduce this.
Please let us know the value of preference org.openstreetmap.josm.gui.history.HistoryBrowserDialogManager.geometry, maybe it contains an invalid value. Try to reset that preference.

My preferences.xml contains

  <tag key='org.openstreetmap.josm.gui.history.HistoryBrowserDialogManager.geometry' value='x=535,y=290,width=850,height=500'/>

[ahoran@…]

Mine has

<tag key='org.openstreetmap.josm.gui.history.HistoryBrowserDialogManager.geometry' value='x=722,y=-625,width=850,height=500'/>

I flipped that negative to a positive and tested again, then the history dialogue did popup.
Although to complicate things I'd also disconnected my second monitor, so it's possible that affected it too.

Several other geometry settings have negative x & y including the PreferenceDialog. That however did open when i just tested it. It's possible the second monitor is a factor in this.

[GerdP]

Yes, a second monitor sounds like a possible source for this problem. I don't have one, so I cannot debug this.

[GerdP]

@Vincent: Why is it worksforme? My understanding that JOSM should somehow detect that the previously stored geometry isn't usable for the current configuration and then fallback to default geometry.
In ToggleDialog we have

            try {
                new WindowGeometry(preferencePrefix+".geometry").applySafe(this);
            } catch (WindowGeometryException e) {
                Logging.debug(e);
                ToggleDialog.this.setPreferredSize(ToggleDialog.this.getDefaultDetachedSize());
                pack();
                setLocationRelativeTo(MainApplication.getMainFrame());
            }

I guess we need something like that in all dialogs.
Forget the above, it's a special case with the ToggleDialogs
Hmm, okay, I just tried with this:

• edit preference.xml and use the user value

<tag key='org.openstreetmap.josm.gui.history.HistoryBrowserDialogManager.geometry' value='x=722,y=-625,width=850,height=500'/>

• start JOSM and display history for an object
• the dialog appears at the top
• press ESC, stop JOSM

now preferences show
<tag key='org.openstreetmap.josm.gui.history.HistoryBrowserDialogManager.geometry' value='x=722,y=0,width=850,height=500'/>
So, the code in JOSM already handles the invalid position, at least for a system with only one monitor.

[ahoran@…]

I've restested with two monitors.

I reinstated the original values above.

I have the RH monitor as primary, and the left as secondary.

I opened JOSM and moved it to the RH monitor, got data, clicked History. No dialogue.
Minimised all windows to check if it was behind anything - cannot find it.

Opened JOSM and moved to the LH monitor - same result. No dialogue.

If i set the y value to be positive, then it appears.
I tried putting my original values in for the preferences dialogue, and that also stops it from opening, so it's not unique to the history dialogue.

My monitors are \Display0 3240x2160 (scaling 1.0x1.0), \Display1 3840x2160 (scaling 1.0x1.0)
Display0 is the RH monitor, and is the primary one.

[ahoran@…]

I've also confirmed that the dialogue is opening off-screen.

In windows if you press ALT, then SPACE, it opens the window dialogue, then press M for Move. You can then use the arrow keys to move the window, even if you cannot see it.
I moved it down and it appeared.

[GerdP]

Replying to ahoran@…:

I've also confirmed that the dialogue is opening off-screen.

In windows if you press ALT, then SPACE, it opens the window dialogue, then press M for Move. You can then use the arrow keys to move the window, even if you cannot see it.
I moved it down and it appeared.

OK. So is it a usual problem with a dual-screen configuration? Does this action fix the problem for further Ctrl+H actions or will the next dialog again pop up off-screen?

[ahoran@…]

Once you've got the dialogue on screen, then I presume it's now valid position is saved for subsequent usage. So subsequent dialogues open where you expect.

My scenario of laptop + external monitors, along with changing usage, is quite common these days.
Programs opening windows off-screen is pretty uncommon in 2020. I can't think when it last happened.

[GerdP]

How does the entry in preferences look like now that all works well?

[ahoran@…]

<tag key='org.openstreetmap.josm.gui.history.HistoryBrowserDialogManager.geometry' value='x=-1958,y=-805,width=970,height=620'/>

This opens it in the middle of the secondary screen.

[GerdP]

So both values x and y are negative, while in the bad string only the y value was negative.
My understanding so far:

• You used JOSM with a two-monitor setup and all worked fine for a while, including Ctrl+H for history.
• You removed one monitor and used Ctrl+H and that still worked. Right?
• You added the 2nd monitor again and Ctrl+H no longer worked but other dialogs like preferences still were OK. Right?