Modify

Opened 4 years ago

Closed 4 years ago

#20181 closed defect (fixed)

managed to crash the new functionality with stop_area relations

Reported by: Polyglot Owned by: michael2402
Priority: normal Milestone:
Component: Plugin pt_assistant Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. I opened a stop_area relation
  2. I removed all the members (they were wrong and I wanted to reuse the relation)
  3. I clicked on the routes buttons

What is the expected result?

It can't really show anything, so nothing, I suppose.

I think this may also happen if a user starts to create a stop_area relation with no members in it initially.

What happens instead?

A null pointer exception

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Revision:17084
Build-Date:2020-10-04 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17084 en) Linux Mint 20
Memory Usage: 240 MB / 3990 MB (46 MB allocated, but free)
Java version: 13.0.3+3-MTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600x900 (scaling 1.0x1.0), :0.1 1920x1080 (scaling 1.0x1.0), :0.2 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Desktop environment: X-Cinnamon
fonts-noto: fonts-noto:-
VM arguments: [-Djosm.cache=<josm.cache>, -Djosm.pref=<josm.pref>, -Djosm.userdata=<josm.userdata>, -Dfile.encoding=UTF-8, -Duser.country=US, -Duser.language=en, -Duser.variant]
Program arguments: [--load-preferences=file:<josm.pref>erences-init.xml]
Dataset consistency test: No problems found

Plugins:
+ pt_assistant_route_master_visualisation (2.1.10-137-g3067d40)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- 00010.445 E: Failed to locate image 'bus.png'
- 00365.788 E: Handled by bug report queue: java.lang.NullPointerException
- 00365.799 E: Handled by bug report queue: java.lang.NullPointerException
- 00365.855 E: Handled by bug report queue: java.lang.NullPointerException


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (18) of main
java.lang.NullPointerException
	at org.openstreetmap.josm.gui.NavigatableComponent.zoomTo(NavigatableComponent.java:843)
	at org.openstreetmap.josm.plugins.pt_assistant.gui.utils.AbstractVicinityPanel.zoomToEditorRelation(AbstractVicinityPanel.java:183)
	at org.openstreetmap.josm.plugins.pt_assistant.gui.stoparea.StopVicinityPanel.doInitialZoom(StopVicinityPanel.java:209)
	at org.openstreetmap.josm.plugins.pt_assistant.gui.utils.AbstractVicinityPanel$2.prepareToDraw(AbstractVicinityPanel.java:96)
	at org.openstreetmap.josm.gui.MapView.paint(MapView.java:479)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JViewport.paint(JViewport.java:737)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
	at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
	at java.desktop/javax.swing.JComponent.paintToOffscreen(JComponent.java:5255)
	at java.desktop/javax.swing.BufferStrategyPaintManager.paint(BufferStrategyPaintManager.java:246)
	at java.desktop/javax.swing.RepaintManager.paint(RepaintManager.java:1323)
	at java.desktop/javax.swing.JComponent._paintImmediately(JComponent.java:5203)
	at java.desktop/javax.swing.JComponent.paintImmediately(JComponent.java:5013)
	at java.desktop/javax.swing.RepaintManager$4.run(RepaintManager.java:865)
	at java.desktop/javax.swing.RepaintManager$4.run(RepaintManager.java:848)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:848)
	at java.desktop/javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:823)
	at java.desktop/javax.swing.RepaintManager.prePaintDirtyRegions(RepaintManager.java:772)
	at java.desktop/javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1884)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:313)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

Attachments (0)

Change History (3)

comment:1 by michael2402, 4 years ago

Both routes and vicinity view now work correctly with empty relations.

comment:2 by michael2402, 4 years ago

Owner: changed from Biswesh to michael2402

comment:3 by michael2402, 4 years ago

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain michael2402.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.