Listener was not registered before or already removed.

[anonymous]

What steps will reproduce the problem?

1. In josm on linux, with mapillary plugin activated, in "data" menu in "edit mode"

What is the expected result?

bein able to edit a mapillary sequence

What happens instead?

unable to use edit mode, it open istead the bug report that request to contact the plugin autor: nokutu, floscher <incoming+josm-plugin-mapillary-8564565-issue-@…>

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-21 14:56:29 +0100 (Sat, 21 Nov 2020)
Revision:17329
Build-Date:2020-11-22 02:30:52
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17329 it) Linux Ubuntu 20.04.1 LTS
Memory Usage: 596 MB / 2048 MB (226 MB allocated, but free)
Java version: 11.0.9.1+1-Ubuntu-0ubuntu1.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1366x768 (scaling 1.0x1.0)
Maximum Screen Size: 1366x768
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Desktop environment: ubuntu:GNOME
Java package: openjdk-11-jre:amd64-11.0.9.1+1-0ubuntu1~20.04
WebStart package: icedtea-netx:amd64-1.8-0ubuntu8
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
Environment variable LANG: it_IT.UTF-8
libcommons-compress-java: libcommons-compress-java:all-1.19-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20200323-1build1~ubuntu20.04.1
liboauth-signpost-java: liboauth-signpost-java:all-1.2.1.2-3
VM arguments: [--add-reads=java.base=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,jdk.jsobject, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, -Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/lib/icedtea-web/bin/javaws]

Plugins:
+ Lanes (${version.entry.commit.revision})
+ Mapillary (1.5.27)
+ OpeningHoursEditor (35640)
+ PicLayer (2a9aa7a)
+ RoadSigns (35640)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools (35640)
+ imagery_offset_db (35640)
+ indoorhelper (eca65b2)
+ javafx-unixoid (35458)
+ jna (35458)
+ measurement (35640)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reltoolbox (35640)
+ rex (53)
+ splinex (35562)
+ tageditor (35640)
+ turnlanes-tagging (288)
+ utilsplugin2 (35640)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- <josm.userdata>/styles/sit.mapcss

Last errors/warnings:
- 00137,750 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = OpenStreetMap Carto (Standard):https://{switch:a,b,c}.tile.openstreetmap.org/{zoom}/{x}/{y}.png/15/17237/11708
- 00137,885 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = OpenStreetMap Carto (Standard):https://{switch:a,b,c}.tile.openstreetmap.org/{zoom}/{x}/{y}.png/15/17236/11709
- 00137,898 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = OpenStreetMap Carto (Standard):https://{switch:a,b,c}.tile.openstreetmap.org/{zoom}/{x}/{y}.png/15/17235/11709
- 00137,901 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = OpenStreetMap Carto (Standard):https://{switch:a,b,c}.tile.openstreetmap.org/{zoom}/{x}/{y}.png/15/17234/11708
- 00137,952 E: Region [TMS_BLOCK_v2] : Failure getting from disk, key = OpenStreetMap Carto (Standard):https://{switch:a,b,c}.tile.openstreetmap.org/{zoom}/{x}/{y}.png/15/17237/11708
- 00175,056 W: Could not load Mapillary brand image!
- 00222,817 E: Handled by bug report queue: java.lang.IllegalArgumentException: Listener Modalità selezione (instance of org.openstreetmap.josm.plugins.mapillary.mode.SelectMode) was not registered before or already removed.
- 00226,140 W: Attenzione - <html>JOSM non riesce a trovare le informazioni riguardanti le seguenti estensioni:<ul><li>indoorhelper</li><li>imagery_offset_db</li><li>apache-commons</li><li>reltoolbox</li><li>rex</li><li>tageditor</li><li>RoadSigns</li><li>Mapillary</li><li>splinex</li><li>measurement</li><li>pt_assistant</li><li>turnlanes-tagging</li><li>utilsplugin2</li><li>javafx-unixoid</li><li>OpeningHoursEditor</li><li>buildings_tools</li><li>Lanes</li><li>jna</li><li>PicLayer</li><li>apache-http</li></ul>Le estensioni non saranno caricate.</html>
- 00255,644 E: Handled by bug report queue: java.lang.IllegalArgumentException: Listener Modalità selezione (instance of org.openstreetmap.josm.plugins.mapillary.mode.SelectMode) was not registered before or already removed.
- 00270,475 W: Attenzione - <html>JOSM non riesce a trovare le informazioni riguardanti le seguenti estensioni:<ul><li>indoorhelper</li><li>imagery_offset_db</li><li>apache-commons</li><li>reltoolbox</li><li>rex</li><li>tageditor</li><li>RoadSigns</li><li>Mapillary</li><li>splinex</li><li>measurement</li><li>pt_assistant</li><li>turnlanes-tagging</li><li>utilsplugin2</li><li>javafx-unixoid</li><li>OpeningHoursEditor</li><li>buildings_tools</li><li>Lanes</li><li>jna</li><li>PicLayer</li><li>apache-http</li></ul>Le estensioni non saranno caricate.</html>


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-1 (36) of JOSM
java.lang.IllegalArgumentException: Listener Modalità selezione (instance of org.openstreetmap.josm.plugins.mapillary.mode.SelectMode) was not registered before or already removed.
	at org.openstreetmap.josm.tools.ListenerList.failRemove(ListenerList.java:138)
	at org.openstreetmap.josm.tools.ListenerList.removeListener(ListenerList.java:132)
	at org.openstreetmap.josm.data.Preferences.removePreferenceChangeListener(Preferences.java:260)
	at org.openstreetmap.josm.actions.mapmode.MapMode.exitMode(MapMode.java:86)
	at org.openstreetmap.josm.plugins.mapillary.gui.layer.MapillaryLayer.setMode(MapillaryLayer.java:208)
	at org.openstreetmap.josm.plugins.mapillary.actions.MapillaryEditAction.actionPerformed(MapillaryEditAction.java:41)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.AbstractButton.doClick(AbstractButton.java:369)
	at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1020)
	at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:1064)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6635)
	at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
	at java.desktop/java.awt.Component.processEvent(Component.java:6400)
	at java.desktop/java.awt.Container.processEvent(Container.java:2263)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5011)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4547)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[taylor.smock]

It looks like I fixed this in ​https://gitlab.com/JOSM/plugin/Mapillary/-/tree/e023220e9aa62a7acfe935b063736ca980cf7617 .

I haven't done a release with that yet though. I'll see if I can finish up my current stream of work and then do a release.

[GerdP]

Not sure how others handle it, but I think a problem is not fixed until a binary was released and the user can access it.

[stoecker]

Replying to GerdP:

Not sure how others handle it, but I think a problem is not fixed until a binary was released and the user can access it.

For JOSM we close tickets as fixed when the issue was fixed in code. We're looking from the programmers side, not from the users point of view :-)

[taylor.smock]

Replying to GerdP:

Not sure how others handle it, but I think a problem is not fixed until a binary was released and the user can access it.

I usually mark as fixed as soon as the fix hits master. Depending upon the severity of the bug (i.e., how easy it is for me to reproduce), I may do a release ASAP. Otherwise, it waits for more changes/stabilization.

TBH, I just put the offending line of code in a try-catch block, checked the exception to make certain that that the error indicated was not registered before or already removed, and if not, rethrow the exception (I don't want to accidentally suppress something). My check will fail if the error is ever translated, but it was the best I could do with my inability to reproduce. Something, somewhere, is either not registering the action or is de-registering the action (probably the former), and I haven't had time to actually figure it out.