Modify

Opened 5 months ago

Last modified 4 months ago

#20159 new defect

Split way: Change "Which way segment should reuse the history" to modal?

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc: simon04, Skyper

Description (last modified by GerdP)

The current code (introduced with r8886) uses setModal(false) and this makes control flow much more complex. I've never noticed that this dialog is not modal. I have no clue what a user might want to do with other dialogs when this dialog pops up

Attachments (2)

whichway.PNG (11.2 KB) - added by GerdP 5 months ago.
20159-count-changes.patch (2.1 KB) - added by GerdP 4 months ago.

Download all attachments as: .zip

Change History (13)

Changed 5 months ago by GerdP

Attachment: whichway.PNG added

comment:1 Changed 5 months ago by GerdP

Description: modified (diff)

comment:2 Changed 5 months ago by GerdP

Cc: Skyper added

OK, one possible reason could be that one wants to check the involved relations after starting the split of the way, but the dialog contains no hint that this should be done if the way is a member of one or more relations.
One reason to choose a different segment might be the number of relations which are changed if the way is split. This number might change when a different segment is selected, e.g. a route restriction needs not to be changed if the shorter segment is selected instead of the longer one.
I'd prefer to have this information in the dialog if - and only if - the number of modified relations differ.

comment:3 Changed 5 months ago by GerdP

Description: modified (diff)

comment:4 Changed 5 months ago by skyper

+1 for more information about affected relations.

Me too, did not notice this non-modal dialog, e.g. I never used its benefits.

I miss a general request to download parent relations of the way if working outside downloaded area or without any download area. This dialog probably needs the common options to disable/enable it for the session and for every.

Last edited 4 months ago by skyper (previous) (diff)

Changed 4 months ago by GerdP

Attachment: 20159-count-changes.patch added

comment:5 Changed 4 months ago by GerdP

patch attachment:20159-count-changes.patch doesn't change the modal stuff, it just uses a different strategy to find the best way segment to keep.
I also tried to change the dialog to modal but that caused unexpected changes like no highlighted selection. Why is it always that complicated when it comes to dialogs?

comment:6 Changed 4 months ago by simon04

The idea of the non-modal dialog was to allow users to inspect which part "highway (7 nodes)" and "highway (4 nodes)" is referring to. Since one or both segments might not currently not be in the view, allowing the user to pan the map view seemed helpful.

comment:7 in reply to:  6 Changed 4 months ago by Klumbumbus

Replying to simon04:

The idea of the non-modal dialog was to allow users to inspect which part "highway (7 nodes)" and "highway (4 nodes)" is referring to. Since one or both segments might not currently not be in the view, allowing the user to pan the map view seemed helpful.

Yes, that feature is important for this action.

comment:8 Changed 4 months ago by GerdP

Found this while thinking about #20213:
Problem is that the code doesn't handle actions which affect the way. Like the relation editor, this dialog is a ticking timebomb. I see all kinds of crashes when I continue editing while this dialog is open, e.g. when I delete the way or the split node or remove the data layer.
I thik if we still want the non-modal dialog we need a way to block most actions, but for me the obvious solution is to avoid non-modal dialogs were possible.

comment:9 Changed 4 months ago by GerdP

Type: enhancementdefect

comment:10 Changed 4 months ago by skyper

Is it possible to allow some zoom actions in this dialog, then?

comment:11 Changed 4 months ago by GerdP

I don't understand what the problem is. If you find out that you don't have enough information you cancel the split, gather that information, and redo the split. Why should we add code to avoid this simple solution?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to GerdP
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.