Modify

Opened 3 months ago

Last modified 3 months ago

#20147 new enhancement

add more tags to hasAreaTags (synchronize with StreetComplete)

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description (last modified by mkoniecz)

Followup to https://josm.openstreetmap.de/ticket/19465#comment:28

improved list in method hasAreaTags(). Probably many more candidates could be added.

Based on what StreetComplete lists, I would add:

man_made ~ beacon|bridge|campanile|dolphin|lighthouse|obelisk|observatory|tower|bunker_silo|chimney|gasometer|kiln|mineshaft|petroleum_well
man_made ~ silo|storage_tank|watermill|windmill|works|communications_tower|monitoring_station|street_cabinet|pumping_station
man_made ~ reservoir_covered|wastewater_plant|water_tank|water_tower|water_well|water_works
waterway ~ boatyard|dam|dock|fuel (waterway=riverbank is listed already)
cemetery ~ sector|grave
craft
office
public_transport
place
tourism
military and military != trench
emergency and emergency != yes and emergency != no

In addition, what it be possible to put tags (at least in the initial list) in the alphabetic order? It would make comparisons much easier. (And yes, listing natural entries in both JOSM and SC in the alphabetic order would be likely helpful)

BTW, I created https://wiki.openstreetmap.org/wiki/Area#Tags_implying_area_status

It may be useful to track down what other editors/software considers as implying an area and synchronize them.

Attachments (0)

Change History (9)

comment:1 Changed 3 months ago by mkoniecz

Description: modified (diff)

comment:2 Changed 3 months ago by mkoniecz

Description: modified (diff)

comment:3 Changed 3 months ago by mkoniecz

Summary: add more tags to hasAreaTagsadd more tags to hasAreaTags (synchronize with StreetComplete)

comment:4 Changed 3 months ago by stoecker

For me only the waterway tags make sense. If we start with adding each and any tag which may be an area we soon have whole taginfo encoded in OsmPrimitve class.

comment:5 Changed 3 months ago by mkoniecz

For me only the waterway tags make sense.

It kind of depends how this data is used, StreetComplete listing needs basically all tags that are areas rather than ways when tagged on a closed line (it is used for rendering area or closed line)

comment:6 Changed 3 months ago by simon04

comment:7 in reply to:  6 ; Changed 3 months ago by Don-vip

Replying to simon04:

Here's the list of area tags used in iD: https://github.com/osmlab/id-area-keys/blob/main/areaKeys.json

Didn't read the whole list, but I disagree with the first key addr:*

comment:9 in reply to:  7 Changed 3 months ago by GerdP

Replying to Don-vip:

Replying to simon04:

Here's the list of area tags used in iD: https://github.com/osmlab/id-area-keys/blob/main/areaKeys.json

Didn't read the whole list, but I disagree with the first key addr:*

It's a bit difficult to compare the lists if you don't know exactly what they are used for. I agree that addr:* looks suspicious, but if I got that right iD checks first if the element is a closed way and in that context it is probably OK.
addr:interpolation=* could be added as an exception.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to mkoniecz
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.