Modify

Opened 3 years ago

Closed 3 years ago

#20086 closed enhancement (fixed)

Indication of choosen preference category vanishes [patch]

Reported by: skyper Owned by: simon04
Priority: normal Milestone:
Component: Plugin flatlaf Version:
Keywords: template_report preferences highlight Cc: DevCharly

Description

What steps will reproduce the problem?

  1. Open preferences
  2. Watch the blue background of the category on the left side
  3. enable/disable expert mode or click on a box on the right side

What is the expected result?

The blue background on the left stays

What happens instead?

The background vanishes

Please provide any additional information below. Attach a screenshot if possible.

I've tested with Metal and there the background stays, so I expect this to be a problem with the theme.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-14 16:31:36 +0100 (Sat, 14 Nov 2020)
Revision:17310
Build-Date:2020-11-15 02:30:52
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17310 en) Linux Debian GNU/Linux 10 (buster)
Java version: 11.0.9+11-post-Debian-1deb10u1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarculaLaf

Plugins:
+ flatlaf (35589)

Attachments (2)

OSM-FlatLaf-plugin-tabbedpane-selection.diff (1.1 KB ) - added by DevCharly 3 years ago.
tabbedpane-selection.png (133.8 KB ) - added by DevCharly 3 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by skyper, 3 years ago

Cc: DevCharly added

comment:2 by DevCharly, 3 years ago

The "bluish" tab background indicates only that the JTabbedPane has focus.
Selected tab is only highlighted by the thick blue line at the right side of the tabs.

This is normal behavior, but I understand that it is hard to recognize the selected tab in the
Preferences dialog.

Luckily it is possible to tell FlatLaf to use another color for selected tabs.
Patch attachment:OSM-FlatLaf-plugin-tabbedpane-selection.diff​ makes the selected tabs slightly darker.
This affects all tabbed panes in JSOM.

comment:3 by Klumbumbus, 3 years ago

Summary: Indication of choosen preference category vanishesIndication of choosen preference category vanishes [patch]

comment:4 by skyper, 3 years ago

Thanks, never realized the blue line as indicator. Thought it is a scroll bar.

Guess it will look similar to the vertical tabs on top in FlatLaf-HideableTabbedPane-fixed.png. Nice.

comment:5 by skyper, 3 years ago

Type: defectenhancement

comment:6 by DevCharly, 3 years ago

In 35697/osm:

see #20086 - Indication of choosen preference category vanishes

use different background color for selected tab in all tabbed panes

comment:7 by skyper, 3 years ago

works now, thanks.

Only when en-/disabling Expert Mode the background color on the left side changes from a light blue to a dark grey but that is no problem for my eyes.

Fixed?

Last edited 3 years ago by skyper (previous) (diff)

by DevCharly, 3 years ago

Attachment: tabbedpane-selection.png added

comment:8 by DevCharly, 3 years ago

Only when en-/disabling Expert Mode the background color on the left side changes from a light blue to a dark grey but that is no problem for my eyes.

This normal. The selected tab is light blue if the tabbedpane has focus.
When you click the "Expert mode" checkbox, the tabbedpane looses focus.

Here is a screenshot that shows the two colors used for selected tab background:


comment:9 by DevCharly, 3 years ago

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.