Update start page link macOS download link

[Stereo]

When we do a 20.10 release, we should update the link for the macOS download on the home page to the new builds at

​https://github.com/openstreetmap/josm/releases/latest/download/JOSM-macOS-java15.zip

The link 404s for now. ​https://github.com/openstreetmap/josm/actions will show the build process. Running all the tests and building a release takes about 25 minutes (but I have ideas to separate tests and builds for 20.11).

[Don-vip]

Replying to Stereo:

The link 404s for now.

What needs to be done to get a proper link?

[Stereo]

A release version of JOSM needs to be built on github.

This is currently decided like this:

          if [[ "$josm_revision" == `curl --silent https://josm.openstreetmap.de/tested` ]]; then
            sed -i .bak '/Is-Local-Build/d' resources/REVISION
            echo "josm_prerelease=false" >> $GITHUB_ENV
          else
            echo "josm_prerelease=true" >> $GITHUB_ENV

In plain language: if my revision is what https://josm.openstreetmap.de/tested returns, I'm not a pre-release.

I'm not familiar with how /tested works, but hope that it will be automatically updated when the milestone completes, long before the git mirror syncs?

[Don-vip]

It can happen long after, as we decide manually to promote a build as the new "tested". From a few minutes to sometimes a few days.

[Stereo]

Oh no! Then the shell script will never evaluate to true, and a re-build has to be triggered when a commit gets tagged as tested.

I'll think about it, but we might be able to use the git tags to do it.

[Don-vip]

Can't we just use GitHub API to perform the release from JOSM server side? This would be the best.

[Stereo]

What happens on the server when a release gets made?

[Don-vip]

Milestone renamed

[Don-vip]

Replying to Stereo:

What happens on the server when a release gets made?

All the required stuff to get everything up to date on JOSM website. If we can call GitHub API we can update the scripts on server side to perform the release there as well.

[Stereo]

I've put in a link to my own 'release' build for 20.11. For 20.12, Don-vip and I are working on automating it.

[Stereo]

Depends on #20146. For now, the links point to my latest build in my fork.

[Stereo]

Ticket #20148 has been marked as a duplicate of this ticket.

[stoecker]

Milestone renamed

[Stereo]

Steps now:

• Finish the three other tickets for 21.02
• Mark the last commit as 'tested' once those three are closed
• @stoecker babysits the process a bit to make sure that the 'stable' re-build gets triggered on GitHub.
• Once a release is built, the links on the wiki get updated to point to ​https://github.com/openstreetmap/josm/releases/latest/download/JOSM-macOS-java15.zip (which then won't be a 404), or the apache redirect gets updated to point to that - dealer's choice.
• Close this ticket

[Stereo]

Sorry Dirk, putting this one on your lap :)

[Don-vip]

Other tickets are done but there is an i18n issue in Russian I couldn't fix yesterday from Launchpad UI :(

[Don-vip]

In 35725/osm:

see #20341 - see #20046 - fix i18n string

[Don-vip]

In 35726/osm:

see #20341 - see #20046 - fix i18n string

[Don-vip]

Release is done on JOSM wiki side.

[stoecker]

Replying to Don-vip:

Release is done on JOSM wiki side.

Did triggering rebuild work?

[Stereo]

It didn't, maybe because the GUI tests get stuck and the previous CI run was still running.

Can someone with the appropriate permissions on the server re-trigger the rebuild and maybe check the logs?

[Stereo]

I've done a release on my github for now.

[stoecker]

Aaargh: Error rebuilding MacOS: Wide character in subroutine entry at /home/josm/josmcron.pl line 206

Why didn't that happen in the tests?

[Stereo]

I don't know, you ran those tests :p. Hope that's not my code?

Can you try giving the github job a kick with your script now?

[stoecker]

Replying to Stereo:

I don't know, you ran those tests :p. Hope that's not my code?

Can you try giving the github job a kick with your script now?

Done. Thought it seems this will take some iterations until it works automatically.

[stoecker]

Zip-File is missing for the tested.

[Don-vip]

If confirmed #20598 will require an hotfix. So we have a chance to test again.

[stoecker]

I improved the code a bit so it tries the individual steps more than once.

[stoecker]

P.S. And download link now downloads the correct file :-)

[Stereo]

Hmm, any error messages in the response? You should be able to re-trigger any action runs, it won't squash the release.

I'm thinking that the build action and the test action should really be separate, so that a release action doesn't run for 6 hours if a test action hangs.

[stoecker]

Replying to Stereo:

Hmm, any error messages in the response? You should be able to re-trigger any action runs, it won't squash the release.

Pretty sure. But I didn't log them last time :-)

I'm thinking that the build action and the test action should really be separate, so that a release action doesn't run for 6 hours if a test action hangs.

Sounds sensible. Go on... :-)

[Don-vip]

FYI Java 16 is GA so 15 is obsolete, I removed it in r17566

[Stereo]

Then we'll also have to update ​https://github.com/homebrew/homebrew-cask/blob/master/Casks/josm.rb - it includes the version number, so there won't be a 404.

I'll try JOSM-macOS-java16.zip to make sure nothing's borken.

[Don-vip]

I just released r17580 as hotfix for #20598

[Stereo]

@stoecker what happens behind the scenes before /tested gets updated and the github action gets re-launched? Did you end up running the git mirror script as a post-commit hook?

[Stereo]

17580 isn't being rebuilt on github.

[stoecker]

Ooops. MacOS revision was hardcoded to 17560 :-(

[stoecker]

Works automatically now.

It triggers a rerun as long as there is no $rev-tested release entry. If the rerun fails later it is not retried. Hope that's ok. When java version changes again, the josmcron.pl needs to be adapted or it wont find the file.

GitHub process should be improved, but that's another ticket. Together with the failing CI stuff. BTW why do we have CI at all on GitHub as we use Jenkins?

Can someone tell me where on GitHub I see the state of the triggered rerun when it still runs?

[Don-vip]

Replying to stoecker:

When java version changes again, the josmcron.pl needs to be adapted

Noted.

[stoecker]

Replying to Don-vip:

Replying to stoecker:

When java version changes again, the josmcron.pl needs to be adapted

Noted.

As it can be done later without breaking (only delaying) the process and I'll get a lot of e-mails when not done that's a minor issue ☺️

[Stereo]

You'll see the actions that are running in ​https://github.com/openstreetmap/josm/actions . So far, nothing since 17589 was pushed a few hours ago.

I suppose the status of all jobs can also be seen at ​https://api.github.com/repos/openstreetmap/josm/actions/runs

[Stereo]

Can the re-run be triggered on github again? What are the errors, if any?

[stoecker]

Replying to Stereo:

Can the re-run be triggered on github again?

Either manually or by deleting the unfinished release on GitHub.

What are the errors, if any?

How should I know? Errors I know about are handled.

[Stereo]

Could you please see what requests it makes, so we can see why r17580 isn't being re-built as stable?

Want us to have a debugging session together? I'm free until 7.

[stoecker]

Replying to Stereo:

Could you please see what requests it makes, so we can see why r17580 isn't being re-built as stable?

Huh, Why?

What are you missing?

[Stereo]

Because I'm an idiot who didn't see ​https://github.com/openstreetmap/josm/releases/tag/17580-tested ? :D

[Stereo]

​https://github.com/openstreetmap/josm/releases/latest/download/JOSM-macOS-java16.zip works for me.

[Stereo]

I see you've already updated everything. Perfect then!