Modify

Opened 3 months ago

Last modified 4 weeks ago

#20046 new task

Update start page link macOS download link

Reported by: Stereo Owned by: Stereo
Priority: normal Milestone: 21.01
Component: Installer MacOS Version:
Keywords: macos Cc:

Description

When we do a 20.10 release, we should update the link for the macOS download on the home page to the new builds at

https://github.com/openstreetmap/josm/releases/latest/download/JOSM-macOS-java15.zip

The link 404s for now. https://github.com/openstreetmap/josm/actions will show the build process. Running all the tests and building a release takes about 25 minutes (but I have ideas to separate tests and builds for 20.11).

Attachments (0)

Change History (10)

comment:1 in reply to:  description Changed 2 months ago by Don-vip

Replying to Stereo:

The link 404s for now.

What needs to be done to get a proper link?

comment:2 Changed 2 months ago by Stereo

A release version of JOSM needs to be built on github.

This is currently decided like this:

          if [[ "$josm_revision" == `curl --silent https://josm.openstreetmap.de/tested` ]]; then
            sed -i .bak '/Is-Local-Build/d' resources/REVISION
            echo "josm_prerelease=false" >> $GITHUB_ENV
          else
            echo "josm_prerelease=true" >> $GITHUB_ENV

In plain language: if my revision is what https://josm.openstreetmap.de/tested returns, I'm not a pre-release.

I'm not familiar with how /tested works, but hope that it will be automatically updated when the milestone completes, long before the git mirror syncs?

Last edited 2 months ago by Don-vip (previous) (diff)

comment:3 Changed 2 months ago by Don-vip

It can happen long after, as we decide manually to promote a build as the new "tested". From a few minutes to sometimes a few days.

comment:4 Changed 2 months ago by Stereo

Oh no! Then the shell script will never evaluate to true, and a re-build has to be triggered when a commit gets tagged as tested.

I'll think about it, but we might be able to use the git tags to do it.

comment:5 Changed 2 months ago by Don-vip

Can't we just use GitHub API to perform the release from JOSM server side? This would be the best.

comment:6 Changed 2 months ago by Stereo

What happens on the server when a release gets made?

comment:7 Changed 2 months ago by Don-vip

Milestone: 20.1020.11

Milestone renamed

comment:8 in reply to:  6 Changed 2 months ago by Don-vip

Replying to Stereo:

What happens on the server when a release gets made?

All the required stuff to get everything up to date on JOSM website. If we can call GitHub API we can update the scripts on server side to perform the release there as well.

comment:9 Changed 2 months ago by Stereo

Milestone: 20.1120.12
Owner: changed from team to Stereo

I've put in a link to my own 'release' build for 20.11. For 20.12, Don-vip and I are working on automating it.

comment:10 Changed 4 weeks ago by stoecker

Milestone: 20.1221.01

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Stereo.
as The resolution will be set.
to The owner will be changed from Stereo to the specified user.
The owner will change to Stereo
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from Stereo to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.