Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 8 days ago

#19987 closed defect (fixed)

False positive unconnected ways warning for ways ending at ferry terminal

Reported by: Famlam Owned by: team
Priority: normal Milestone: 20.11
Component: Core validator Version: tested
Keywords: template_report unconnected unconnectedways ferry ferry_terminal Cc:

Description

What steps will reproduce the problem?

  1. Validate attached file (part of Rotterdam, NL)
  2. End node of way near other way

What is the expected result?

Ways are allowed to end at ferry terminals; no warning

What happens instead?

Warning

Please provide any additional information below. Attach a screenshot if possible.

Probably requires adding amenity=ferry_terminal to https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/UnconnectedWays.java#L101

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Build-Date:2020-10-04 01:30:47
Revision:17084
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17084 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 798 MB / 1820 MB (594 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ imagery_offset_db (35405)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ reverter (35556)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ undelete (35521)
+ utilsplugin2 (35487)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Attachments (1)

ferry.osm (20.9 KB) - added by Famlam 5 weeks ago.

Download all attachments as: .zip

Change History (4)

Changed 5 weeks ago by Famlam

Attachment: ferry.osm added

comment:1 Changed 5 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17257/josm:

fix #19987 - Fix false positive unconnected ways warning for ways ending at ferry terminal (patch by Famlam)

comment:2 Changed 5 weeks ago by Klumbumbus

Milestone: 20.10

comment:3 Changed 8 days ago by Don-vip

Milestone: 20.1020.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.