Modify

Opened 6 weeks ago

Closed 6 weeks ago

Last modified 8 days ago

#19980 closed enhancement (fixed)

Warn about highway=livingstreet together with maxspeed>20km/h

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 20.11
Component: Core validator Version:
Keywords: Cc:

Description (last modified by Klumbumbus)

From https://github.com/osm-fr/osmose-backend/issues/1008

It might be controversial if maxspeed=walk is allowed or if maxspeed should be mapped at all on highway=livingstreet and the situation is different in each country. But maxspped>20 should always be an error (https://wiki.openstreetmap.org/wiki/Tag:highway%3Dliving_street#National_specialities).

Attachments (0)

Change History (15)

comment:1 Changed 6 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17247/josm:

fix #19980 - Warn about highway=livingstreet together with maxspeed>20km/h

comment:2 Changed 6 weeks ago by Klumbumbus

Description: modified (diff)

comment:3 Changed 6 weeks ago by skyper

There is another informal warning suspicious combination about maxspeed together with living_street. Think it is in the "German rules" which leads to two warnings for one issue, now. This additional rule needs to be adjusted.

comment:4 Changed 6 weeks ago by GerdP

I also wonder if 20 mph should be treated equal to 20 kmh?

comment:5 in reply to:  3 ; Changed 6 weeks ago by Klumbumbus

Replying to skyper:

There is another informal warning suspicious combination about maxspeed together with living_street. Think it is in the "German rules" which leads to two warnings for one issue, now. This additional rule needs to be adjusted.

Yes, it is in wiki:/Rules/GermanySpecific, but as not everyone has this external rule activated, the rule from this ticket makes sense in germany too, at the (low) cost of a double warning for german living streets with maxspeed>20.

comment:6 in reply to:  4 Changed 6 weeks ago by Klumbumbus

Replying to GerdP:

I also wonder if 20 mph should be treated equal to 20 kmh?

I assumed that there are not much cases with maxspeed=20 mph, but actually there are (overpass turbo wizard: type:way and maxspeed="20 mph" and highway=living_street global).
I'll adjust the rule to warn about >15mph.

comment:7 Changed 6 weeks ago by Klumbumbus

In 17253/josm:

see #19980 - Warn about highway=livingstreet together with maxspeed>15 mph (instead of >20 mph)

comment:8 in reply to:  5 ; Changed 6 weeks ago by skyper

Replying to Klumbumbus:

Replying to skyper:

There is another informal warning suspicious combination about maxspeed together with living_street. Think it is in the "German rules" which leads to two warnings for one issue, now. This additional rule needs to be adjusted.

Yes, it is in wiki:/Rules/GermanySpecific, but as not everyone has this external rule activated, the rule from this ticket makes sense in germany too, at the (low) cost of a double warning for german living streets with maxspeed>20.

How about running the German rule only for maxspeed<21:

  • Version

     
    1818}
    1919
    20 way[highway=living_street][maxspeed][maxspeed!=walk][inside("DE")] {
     20way[highway=living_street][maxspeed][maxspeed!=walk][get(split(" ", tag(maxspeed)), 0) < 21][inside("DE")] {
    2121  throwWarning: "{0.tag} zusammen mit {1.key}. Verkehrsberuhigte Bereiche sollten in Deutschland keine expliziten Höchstgeschwindigkeiten enthalten. Möglicherweise ist nicht {1.key} falsch, sondern {0.tag}.";
    2222  fixRemove: "maxspeed";

comment:9 in reply to:  8 Changed 6 weeks ago by Klumbumbus

Replying to skyper:

How about running the German rule only for maxspeed<21:

Yes, we can do that. Please add a comment there linking here.

comment:10 Changed 6 weeks ago by skyper

comment:11 Changed 4 weeks ago by gaben

Wait. There is a Territories java class and an internal .osm file containing all countries. Wouldn't be easier to use that polygon for these checks? It would catch issues where the limit is lower than usual.

I use this code to look up each object's country code for phone checks in my unreleased phone number validator plugin.

comment:12 Changed 3 weeks ago by skyper

Do not know if I complete understood your remarks but we do not need every single rule for only a few countries in core.
The German Rules contain the polygon check.

Phone numbers are a different case, as, this tag is used around the entire world, but needs special handling per country.

BTW: Is there a planned release date for your plugin. I'd like to test it.

comment:13 Changed 3 weeks ago by gaben

The linked wiki page says the maximum speed on these streets in Norway is 8 (km/h). If I understood correctly, this rule in JOSM core will not catch an error where the limit is between 8 and 20.

Similarly in Croatia, Denmark, Iceland and the Netherlands with their limits, all under 20 (km/h).

Phone validation: follow #15250 for more.

comment:14 Changed 3 weeks ago by skyper

In general, I do not like highway=living_street. Should be living_street=yes with the proper highway=*.

This test should find living_streets with too high speed limit, which is either wrong highway=* or a wrong maxspeed=*

Talking about Germany, there is a special traffic sign but no speed limit sign. The speed limit is "walking speed" which either needs an own maxspeed value or should just be not set, as it can be derived from highway=living_street.

I do not know how other community handle this issue and if there is an explicit value mentioned in the other countries regulations.

comment:15 Changed 8 days ago by Don-vip

Milestone: 20.1020.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.