Opened 5 years ago

Last modified 5 years ago

#19939 closed enhancement

[RFC] [Patch] Replace ParentRelationLoadingTask by DownloadReferrersTask — at Version 2

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.11
Component: Core Version:
Keywords: Cc: Don-vip, stoecker

Description (last modified by GerdP)

We have two very different classes which can download the parents of a relation:

  • DownloadReferrersTask (used in Dialog for Download parent ways/relations... action and also in the Download object... action)
  • ParentRelationLoadingTask(only used in relation editor for the Reloadbutton in the parents tab, found no plugin that uses it

For the first one we have a unit test, and it is frequently used. The second one is probably rarely used.
The patch implements the changes to replace the class and removes ParentRelationLoadingTask.

Change History (3)

by GerdP, 5 years ago

Attachment: 19939.patch​ added

comment:1 by GerdP, 5 years ago

Cc: Don-vip stoecker added
Milestone: → 20.10
Summary: [Patch] Replace ParentRelationLoadingTask by DownloadReferrersTask → [RFC] [Patch] Replace ParentRelationLoadingTask by DownloadReferrersTask

Is it OK to simply remove a class that was in use since r1856? Or should it first be deprecated?

comment:2 by GerdP, 5 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.