Modify

Opened 6 days ago

Closed 6 days ago

#19939 closed enhancement (fixed)

[RFC] [Patch] Replace ParentRelationLoadingTask by DownloadReferrersTask

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.10
Component: Core Version:
Keywords: Cc: Don-vip, stoecker

Description (last modified by GerdP)

We have two very different classes which can download the parents of a relation:

  • DownloadReferrersTask (used in Dialog for Download parent ways/relations... action and also in the Download object... action)
  • ParentRelationLoadingTask(only used in relation editor for the Reloadbutton in the parents tab, found no plugin that uses it

For the first one we have a unit test, and it is frequently used. The second one is probably rarely used.
The patch implements the changes to replace the class and removes ParentRelationLoadingTask.

Attachments (1)

19939.patch (11.4 KB) - added by GerdP 6 days ago.

Download all attachments as: .zip

Change History (7)

Changed 6 days ago by GerdP

Attachment: 19939.patch added

comment:1 Changed 6 days ago by GerdP

Cc: Don-vip stoecker added
Milestone: 20.10
Summary: [Patch] Replace ParentRelationLoadingTask by DownloadReferrersTask[RFC] [Patch] Replace ParentRelationLoadingTask by DownloadReferrersTask

Is it OK to simply remove a class that was in use since r1856? Or should it first be deprecated?

comment:2 Changed 6 days ago by GerdP

Description: modified (diff)

comment:3 Changed 6 days ago by stoecker

Did you check plugins? If not used there, drop it :-)

comment:4 Changed 6 days ago by GerdP

I searched the plugin sources and the *.jar files in dist directory and found no plugin using it. Is there another good way to verify?

comment:5 in reply to:  4 Changed 6 days ago by stoecker

Replying to GerdP:

Is there another good way to verify?

Check in and wait for cries :-)

comment:6 Changed 6 days ago by GerdP

Resolution: fixed
Status: newclosed

In 17206/josm:

fix #19939 Replace ParentRelationLoadingTask by DownloadReferrersTask

  • remove class ParentRelationLoadingTask
  • adapt code to use DownloadReferrersTask instead

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.