#19937 closed enhancement (fixed)
Update macOS build process
| Reported by: | Stereo | Owned by: | Don-vip |
|---|---|---|---|
| Priority: | normal | Milestone: | 20.11 |
| Component: | Installer MacOS | Version: | |
| Keywords: | github | Cc: |
Description (last modified by )
Hi,
https://github.com/openstreetmap/josm/pull/65/files describes the changes required to get actual macOS releases built on GitHub Actions. https://github.com/openstreetmap/josm/pull/65.diff is the machine-readable diff.
Because the tests are currently failing, the action has been configured to only run on macos, and to build automatically instead of waiting for the tests to fail.
https://github.com/thomersch/josm/releases has a few test releases. If the build number isn't the same as tested, the releases get marked as pre-releases.
The next step will be to trigger some kind of update on the main wiki page when a release is actually built.
Attachments (0)
Change History (17)
comment:1 by , 4 years ago
| Description: | modified (diff) |
|---|
comment:5 by , 4 years ago
Just scratching my own itch :).
As @Don-vip has pointed out, Java 14 is actually not supported anymore already. Before this can really be used for releases, we'll have to get Java 15 builds going. My previous attempts have been abominable failures: https://github.com/thomersch/josm/runs/1259479550
comment:7 by , 4 years ago
Almost there! Java 15's jpackage has removed a dylib, and codesign fails on that.
Would it please be possible to delete line 73 of native/macosx/macos-jpackage.sh? Where it says:
app/JOSM.app/Contents/MacOS/libapplauncher.dylib \
and then because I messed up the path, in .github/workflows/ant.yml update line 140 near the bottom from:
asset_path: app/josm-custom.jar
to:
asset_path: dist/josm-custom.jar
comment:9 by , 4 years ago
| Milestone: | → 20.10 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:10 by , 4 years ago
https://github.com/openstreetmap/josm/releases now contains a macOS app on every build. Thank you all! I'll ask people to test it to find any eventual bugs before 20.10.
comment:11 by , 4 years ago
I see only Java 15 builds, we need also to ship LTS builds (8 and 11). Also 16-ea would be very useful to test Java bugfixes.
follow-up: 13 comment:12 by , 4 years ago
Since jpackager only supports 14 and up, I had no plans to do that. If someone really wants to build JOSM.app for Java 8 or 11 (why?), I guess they can use the legacy build process?
Noted for 16.
comment:13 by , 4 years ago
Replying to Stereo:
Since jpackager only supports 14 and up
I forgot about that, you're right. So we'll start to provide LTS builds this way with Java 17 then.
comment:14 by , 4 years ago
| Keywords: | github added |
|---|
comment:16 by , 4 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
This seems to work well enough. Closing.
There's a known issue where JOSM closes when you open it for the first time, but opens fine every time after that. Tracking in #20033
On linking to the latest release: according to https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/linking-to-releases we can just link to https://github.com/openstreetmap/josm/releases/latest/download/JOSM-macos.zip.
The nightlies download page can just link to all releases at https://github.com/openstreetmap/josm/releases/ to also show the ones classified as prerelease.